Another problem with pk pull of linuxppc-2.4

Another problem with pk pull of linuxppc-2.4

[Stephen Williams]

The ibm405gpr.h header file is missing the definition of OPB_BASE_START.
I copied the definitions from the linuxppc_2_4_devel tree and it worked
just fine, so I believe this is a correct patch.

According to bk, this file hasn't been changed in linuxppc-2.4 in over
a year (2003-03-12) so *how* pray tell have people been compiling this
thing for PPC405GPr? Who's the right party for getting this patch
installed?

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/06/11 08:49:06-07:00 steve@wing.XXXXXXXXXX
#   Defines of OPB_BASE_START needed by ibm405gpr.c,
#   which does not include ibm405gp.h.
#
# arch/ppc/platforms/ibm405gpr.h
#   2004/06/11 08:49:04-07:00 steve@wing.XXXXXXXXXX +2 -0
#   Defines of OPB_BASE_START needed by ibm405gpr.c,
#   which does not include ibm405gp.h.
#
diff -Nru a/arch/ppc/platforms/ibm405gpr.h b/arch/ppc/platforms/ibm405gpr.h
--- a/arch/ppc/platforms/ibm405gpr.h    2004-06-11 08:50:46 -07:00
+++ b/arch/ppc/platforms/ibm405gpr.h    2004-06-11 08:50:46 -07:00
@@ -75,6 +75,8 @@
  #define PPC4xx_ONB_IO_PADDR    ((uint)0xef600000)
  #define PPC4xx_ONB_IO_VADDR    PPC4xx_ONB_IO_PADDR
  #define PPC4xx_ONB_IO_SIZE     ((uint)4*1024)
+#define OPB_BASE_START        0x40000000
+#define EBIU_BASE_START       0xF0100000

  /* serial port defines */
  #define RS_TABLE_SIZE  2



--
Steve Williams                "The woods are lovely, dark and deep.
steve at XXXXXXXXXX           But I have promises to keep,
http://www.XXXXXXXXXX         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: Another problem with pk pull of linuxppc-2.4

[Matt Porter]

On Fri, Jun 11, 2004 at 08:52:44AM -0700, Stephen Williams wrote:
>
> The ibm405gpr.h header file is missing the definition of OPB_BASE_START.
> I copied the definitions from the linuxppc_2_4_devel tree and it worked
> just fine, so I believe this is a correct patch.

Yep.

> According to bk, this file hasn't been changed in linuxppc-2.4 in over
> a year (2003-03-12) so *how* pray tell have people been compiling this
> thing for PPC405GPr? Who's the right party for getting this patch
> installed?

Applied. I'm the right person for 4xx things. Paul posted the various
people that handle patches recently on two occasions.

FWIW, this means that (1) nobody has tried compiling linuxppc-2.4 for
405gpr in a long time (2) it probably broke during the 2.4 OCP rewrite
but its not any developer's primary devel platform (3) Everybody is
concentrating on 2.6...I know that it works fine there. :)

Thanks for the patch.

-Matt

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/