From: Hari Bathini <hbathini@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Michael Ellerman <mpe@ellerman.id.au>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Pingfan Liu <piliu@redhat.com>,
Kexec-ml <kexec@lists.infradead.org>,
Petr Tesarik <ptesarik@suse.cz>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Sourabh Jain <sourabhjain@linux.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Mimi Zohar <zohar@linux.ibm.com>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 02/11] powerpc/kexec_file: mark PPC64 specific code
Date: Mon, 29 Jun 2020 11:53:08 +0530 [thread overview]
Message-ID: <29542b4a-eb44-5330-60e8-c0b0d294d72f@linux.ibm.com> (raw)
In-Reply-To: <68d59c00-da02-b362-7bd9-a9631eca0fdd@csgroup.eu>
Hi Christophe
Thanks for the review...
On 27/06/20 12:12 pm, Christophe Leroy wrote:
>
>
> Le 26/06/2020 à 21:04, Hari Bathini a écrit :
>> Some of the kexec_file_load code isn't PPC64 specific. Move PPC64
>> specific code from kexec/file_load.c to kexec/file_load_64.c. Also,
>> rename purgatory/trampoline.S to purgatory/trampoline_64.S in the
>> same spirit.
>
> At the time being, CONFIG_KEXEC_FILE depends on PPC64.
Right.
> Are you planning to make it work on PPC32 as well ?
No.
> Otherwise I don't understand the purpose of this patch.
But I want to make sure the changes I am adding in this series do not
get in the way of adding PPC32 changes whenever they are submitted as there
is common code currently and some more of it in the changes I am adding
in this series...
> Also, what is being done in this patch seems to go far beyond what you describe above.> It is propably worth splitting in several patches with proper explanation.
Hmmm.. I don't see any other reason beyond what I mentioned above.
Will try to split the patch but the changelog would still be the same, afaics.
> Christophe
>
>>
>> Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
>> ---
>> arch/powerpc/include/asm/kexec.h | 11 +++
>> arch/powerpc/kexec/Makefile | 2 -
>> arch/powerpc/kexec/elf_64.c | 7 +-
>> arch/powerpc/kexec/file_load.c | 37 ++--------
>> arch/powerpc/kexec/file_load_64.c | 108 ++++++++++++++++++++++++++++++
>> arch/powerpc/purgatory/Makefile | 4 +
>> arch/powerpc/purgatory/trampoline.S | 117 --------------------------------
>> arch/powerpc/purgatory/trampoline_64.S | 117 ++++++++++++++++++++++++++++++++
>> 8 files changed, 248 insertions(+), 155 deletions(-)
>> create mode 100644 arch/powerpc/kexec/file_load_64.c
>> delete mode 100644 arch/powerpc/purgatory/trampoline.S
>> create mode 100644 arch/powerpc/purgatory/trampoline_64.S
Thanks
Hari
next prev parent reply other threads:[~2020-06-29 6:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 19:04 [PATCH 00/11] ppc64: enable kdump support for kexec_file_load syscall Hari Bathini
2020-06-26 19:04 ` [PATCH 01/11] kexec_file: allow archs to handle special regions while locating memory hole Hari Bathini
2020-06-27 6:30 ` Christophe Leroy
2020-06-28 2:28 ` piliu
2020-06-29 6:00 ` Hari Bathini
2020-06-29 11:39 ` Petr Tesarik
2020-06-29 11:56 ` Hari Bathini
2020-07-01 7:46 ` Dave Young
2020-07-01 18:31 ` Hari Bathini
2020-07-02 11:47 ` Dave Young
2020-06-26 19:04 ` [PATCH 02/11] powerpc/kexec_file: mark PPC64 specific code Hari Bathini
2020-06-27 6:42 ` Christophe Leroy
2020-06-29 6:23 ` Hari Bathini [this message]
2020-06-26 19:05 ` [PATCH 03/11] powerpc/kexec_file: add helper functions for getting memory ranges Hari Bathini
2020-06-26 19:05 ` [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions Hari Bathini
2020-06-28 2:14 ` piliu
2020-06-29 5:55 ` Hari Bathini
2020-06-30 3:30 ` piliu
2020-06-30 6:10 ` Hari Bathini
2020-06-30 8:13 ` piliu
2020-07-01 7:40 ` Dave Young
2020-07-01 12:53 ` piliu
2020-07-02 11:59 ` Dave Young
2020-07-01 18:18 ` Hari Bathini
2020-07-02 11:54 ` Dave Young
2020-06-26 19:05 ` [PATCH 05/11] powerpc/drmem: make lmb walk a bit more flexible Hari Bathini
2020-06-26 19:05 ` [PATCH 06/11] ppc64/kexec_file: restrict memory usage of kdump kernel Hari Bathini
2020-06-26 19:05 ` [PATCH 07/11] ppc64/kexec_file: add support to relocate purgatory Hari Bathini
2020-06-26 19:05 ` [PATCH 08/11] ppc64/kexec_file: setup the stack for purgatory Hari Bathini
2020-06-26 19:05 ` [PATCH 09/11] ppc64/kexec_file: setup backup region for kdump kernel Hari Bathini
2020-06-26 19:06 ` [PATCH 10/11] ppc64/kexec_file: prepare elfcore header for crashing kernel Hari Bathini
2020-06-26 19:06 ` [PATCH 11/11] ppc64/kexec_file: add appropriate regions for memory reserve map Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29542b4a-eb44-5330-60e8-c0b0d294d72f@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bauerman@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=piliu@redhat.com \
--cc=ptesarik@suse.cz \
--cc=sourabhjain@linux.ibm.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).