[PATCH 1/4 v4] powerpc: document phy-connection-type property

[PATCH 1/4 v4] powerpc: document phy-connection-type property

[Kim Phillips]

Since ucc_geth is being migrated to use the phylib, the existing
(undocumented) 'interface' property is being deprecated in favour
of 'phy-connection-type'.

phy-connection-type is now maintained one-to-one with definitions
in include/linux/phy.h, albeit in the form of a string.
If not specified, "mii" is assumed.

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
name change since [patch 1/4 v3]: s/interface-type/phy-connection-type/g

 Documentation/powerpc/booting-without-of.txt |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index 88cdb59..f9111cc 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -1562,6 +1562,9 @@ platforms are moved over to use the flattened-device-tree model.
      network device.  This is used by the bootwrapper to interpret
      MAC addresses passed by the firmware when no information other
      than indices is available to associate an address with a device.
+   - phy-connection-type : a string naming the controller/PHY interface type,
+     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", "tbi",
+     or "rtbi".
 
    Example:
 	ucc@2000 {
@@ -1573,6 +1576,7 @@ platforms are moved over to use the flattened-device-tree model.
 		interrupts = <a0 0>;
 		interrupt-parent = <700>;
 		mac-address = [ 00 04 9f 00 23 23 ];
+		phy-connection-type = "gmii";
 		rx-clock = "none";
 		tx-clock = "clk9";
 		phy-handle = <212000>;
-- 
1.5.0.3

Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Segher Boessenkool]

> Since ucc_geth is being migrated to use the phylib, the existing
> (undocumented) 'interface' property is being deprecated in favour
> of 'phy-connection-type'.

Okay.

> phy-connection-type is now maintained one-to-one with definitions
> in include/linux/phy.h, albeit in the form of a string.

That's sort-of accidental though :-)

> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1562,6 +1562,9 @@ platforms are moved over to use the 
> flattened-device-tree model.
>       network device.  This is used by the bootwrapper to interpret
>       MAC addresses passed by the firmware when no information other
>       than indices is available to associate an address with a device.
> +   - phy-connection-type : a string naming the controller/PHY 
> interface type,
> +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", 
> "tbi",
> +     or "rtbi".

Could you put this right after the "phy-handle" definition
please?

> @@ -1573,6 +1576,7 @@ platforms are moved over to use the 
> flattened-device-tree model.
>  		interrupts = <a0 0>;
>  		interrupt-parent = <700>;
>  		mac-address = [ 00 04 9f 00 23 23 ];
> +		phy-connection-type = "gmii";
>  		rx-clock = "none";
>  		tx-clock = "clk9";
>  		phy-handle = <212000>;

Same here.  It's nice to keep things grouped, it
improves understanding ;-)


Segher

Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Kim Phillips]

On Mon, 23 Apr 2007 22:59:43 +0200
Segher Boessenkool <segher@kernel.crashing.org> wrote:

> > phy-connection-type is now maintained one-to-one with definitions
> > in include/linux/phy.h, albeit in the form of a string.
> 
> That's sort-of accidental though :-)
> 
sure..

> > --- a/Documentation/powerpc/booting-without-of.txt
> > +++ b/Documentation/powerpc/booting-without-of.txt
> > @@ -1562,6 +1562,9 @@ platforms are moved over to use the 
> > flattened-device-tree model.
> >       network device.  This is used by the bootwrapper to interpret
> >       MAC addresses passed by the firmware when no information other
> >       than indices is available to associate an address with a device.
> > +   - phy-connection-type : a string naming the controller/PHY 
> > interface type,
> > +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", 
> > "tbi",
> > +     or "rtbi".
> 
> Could you put this right after the "phy-handle" definition
> please?

phy-handle is a required property, whereas phy-connection-type is not
(it's recommended). Are you suggesting phy-connection-type be a required
property?

> 
> > @@ -1573,6 +1576,7 @@ platforms are moved over to use the 
> > flattened-device-tree model.
> >  		interrupts = <a0 0>;
> >  		interrupt-parent = <700>;
> >  		mac-address = [ 00 04 9f 00 23 23 ];
> > +		phy-connection-type = "gmii";
> >  		rx-clock = "none";
> >  		tx-clock = "clk9";
> >  		phy-handle = <212000>;
> 
> Same here.  It's nice to keep things grouped, it
> improves understanding ;-)

That's understandable.  Lemme know about the above though.

Kim

Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Segher Boessenkool]

>>> +   - phy-connection-type : a string naming the controller/PHY
>>> interface type,
>>> +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id",
>>> "tbi",
>>> +     or "rtbi".
>>
>> Could you put this right after the "phy-handle" definition
>> please?
>
> phy-handle is a required property, whereas phy-connection-type is not
> (it's recommended). Are you suggesting phy-connection-type be a 
> required
> property?

Oh okay, I didn't see that from context -- no, it
shouldn't be required, most controllers / PHYs don't
need that information.


Segher

Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Matt Sealey]

Hi guys,

Since I'm poking around on 52xx I had a query - firstly it doesn't
look like the 52xx fec driver uses phylib at all since it also tries
to support the 7-wire ethernet interface, which isn't ?? supported
by phylib.

Stumbling across this property I wondered, if the driver can check
the device tree for the phy type to set it up properly in this
manner, would it also be relevant to list the 7-wire style of
connection, so that drivers can provide the alternative code?

Side note, is phylib flexible enough to support the 7-wire
non-MII connection? It looks sorta so, but...

-- 
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations

Kim Phillips wrote:
> On Mon, 23 Apr 2007 22:59:43 +0200
> Segher Boessenkool <segher@kernel.crashing.org> wrote:
> 
>>> phy-connection-type is now maintained one-to-one with definitions
>>> in include/linux/phy.h, albeit in the form of a string.
>> That's sort-of accidental though :-)
>>
> sure..
> 
>>> --- a/Documentation/powerpc/booting-without-of.txt
>>> +++ b/Documentation/powerpc/booting-without-of.txt
>>> @@ -1562,6 +1562,9 @@ platforms are moved over to use the 
>>> flattened-device-tree model.
>>>       network device.  This is used by the bootwrapper to interpret
>>>       MAC addresses passed by the firmware when no information other
>>>       than indices is available to associate an address with a device.
>>> +   - phy-connection-type : a string naming the controller/PHY 
>>> interface type,
>>> +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", 
>>> "tbi",
>>> +     or "rtbi".
>> Could you put this right after the "phy-handle" definition
>> please?
> 
> phy-handle is a required property, whereas phy-connection-type is not
> (it's recommended). Are you suggesting phy-connection-type be a required
> property?
> 
>>> @@ -1573,6 +1576,7 @@ platforms are moved over to use the 
>>> flattened-device-tree model.
>>>  		interrupts = <a0 0>;
>>>  		interrupt-parent = <700>;
>>>  		mac-address = [ 00 04 9f 00 23 23 ];
>>> +		phy-connection-type = "gmii";
>>>  		rx-clock = "none";
>>>  		tx-clock = "clk9";
>>>  		phy-handle = <212000>;
>> Same here.  It's nice to keep things grouped, it
>> improves understanding ;-)
> 
> That's understandable.  Lemme know about the above though.
> 
> Kim
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Segher Boessenkool]

> Since I'm poking around on 52xx I had a query - firstly it doesn't
> look like the 52xx fec driver uses phylib at all since it also tries
> to support the 7-wire ethernet interface, which isn't ?? supported
> by phylib.
>
> Stumbling across this property I wondered, if the driver can check
> the device tree for the phy type to set it up properly in this
> manner, would it also be relevant to list the 7-wire style of
> connection, so that drivers can provide the alternative code?

Is that 7-wire thing just another kind of connection
to a PHY?  If so, treat it as such (add phylib support
perhaps); if not, have an empty property in your 5200
ethernet node that says the 7-wire thing is in use.


Segher

Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Segher Boessenkool]

>> Since ucc_geth is being migrated to use the phylib, the existing
>> (undocumented) 'interface' property is being deprecated in favour
>> of 'phy-connection-type'.
>
> Okay.

To be perfectly clear about this -- the only reason to
not have it in the PHY node instead is that supposedly
a PHY can be connected on multiple different kinds of
interface at the same time (physically).  Don't ask me
who designs boards like that, but there you have it.


Segher