From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Balbir Singh <bsingharora@gmail.com>
Cc: "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>,
"open list:KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC"
<kvm-ppc@vger.kernel.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel 2/2] KVM: PPC: Allow backing bigger guest IOMMU pages with smaller physical pages
Date: Wed, 2 May 2018 19:13:32 +1000 [thread overview]
Message-ID: <29b2f646-f110-83af-dbbe-8e4584b48ab8@ozlabs.ru> (raw)
In-Reply-To: <CAKTCnzkfXjj4o7NRUsjgDOenZjgcxbhUbOgBw84eqi63JzC5pg@mail.gmail.com>
On 2/5/18 6:59 pm, Balbir Singh wrote:
>>>
>>>> + unsigned long subpg;
>>>
>>> Why not just i?
>>
>> I can imagine pages so huge so backing them with 4K will overflow 32bit
>> anyway. It is very (very) unlikely but it is 64bit arch anyway and there is
>> no much point in not-long types anyway.
>>
>
> What David said, i is an easy iterator to understand :)
Ah, blind me. The reason for this is there is another "i" in the caller and
I found it easier not to mix this "i" (host TCE entry number) with that "i"
(guest TCE entry number).
--
Alexey
next prev parent reply other threads:[~2018-05-02 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 4:07 [PATCH kernel 0/2] KVM: PPC: Allow backing bigger guest IOMMU pages with smaller physical Alexey Kardashevskiy
2018-05-02 4:07 ` [PATCH kernel 1/2] KVM: PPC: Use correct page shift in H_STUFF_TCE Alexey Kardashevskiy
2018-05-02 5:41 ` David Gibson
2018-05-02 4:07 ` [PATCH kernel 2/2] KVM: PPC: Allow backing bigger guest IOMMU pages with smaller physical pages Alexey Kardashevskiy
2018-05-02 5:49 ` David Gibson
2018-05-02 9:10 ` Alexey Kardashevskiy
2018-05-02 5:53 ` Balbir Singh
2018-05-02 6:26 ` Alexey Kardashevskiy
2018-05-02 7:03 ` David Gibson
2018-05-02 8:59 ` Balbir Singh
2018-05-02 9:13 ` Alexey Kardashevskiy [this message]
2018-05-02 6:16 ` [PATCH kernel 0/2] KVM: PPC: Allow backing bigger guest IOMMU pages with smaller physical David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b2f646-f110-83af-dbbe-8e4584b48ab8@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=bsingharora@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).