From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40bXdH25c3zF2SZ for ; Wed, 2 May 2018 19:13:39 +1000 (AEST) Received: by mail-io0-x234.google.com with SMTP id d11-v6so16616533iof.11 for ; Wed, 02 May 2018 02:13:38 -0700 (PDT) Subject: Re: [PATCH kernel 2/2] KVM: PPC: Allow backing bigger guest IOMMU pages with smaller physical pages To: Balbir Singh Cc: "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "open list:KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC" , David Gibson References: <20180502040723.20545-1-aik@ozlabs.ru> <20180502040723.20545-3-aik@ozlabs.ru> <20180502155323.30c41ce4@balbir.ozlabs.ibm.com> From: Alexey Kardashevskiy Message-ID: <29b2f646-f110-83af-dbbe-8e4584b48ab8@ozlabs.ru> Date: Wed, 2 May 2018 19:13:32 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2/5/18 6:59 pm, Balbir Singh wrote: >>> >>>> + unsigned long subpg; >>> >>> Why not just i? >> >> I can imagine pages so huge so backing them with 4K will overflow 32bit >> anyway. It is very (very) unlikely but it is 64bit arch anyway and there is >> no much point in not-long types anyway. >> > > What David said, i is an easy iterator to understand :) Ah, blind me. The reason for this is there is another "i" in the caller and I found it easier not to mix this "i" (host TCE entry number) with that "i" (guest TCE entry number). -- Alexey