From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CACCEB64DC for ; Fri, 21 Jul 2023 15:43:15 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=GgiGdld9; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R6v353wwQz3cN9 for ; Sat, 22 Jul 2023 01:43:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=GgiGdld9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=xiaoyao.li@intel.com; receiver=lists.ozlabs.org) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R6v272HMHz2ys2 for ; Sat, 22 Jul 2023 01:42:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689954143; x=1721490143; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=dgWqCDpNSWuzZvJih5GvRdqDtkxO0fYOrqXInsikkp8=; b=GgiGdld962Ryw3JSogBzVWmHxgNrV1jqSi+GjrRCurx9UlJskalZze5j m+B9QnFzSnPkkOEQDHm+YmQfUs1oAYSGKAWwg40LGGyudhEZIxyVu53Re 1DOcaiXhzKHLEao6cWkEu15HmFDqEDDROxM2BWpREcGbvyWSjZdSdW1ii oTFZo6GDpIqrhjjarG6VlgCwxS7BT4ir2yfLaxP6B4LSrE0yKCgQR4zko jBqnMMYcAAT0Rsf4whISIKk5MQeK0p6TlsoEz8ZaJamBRjq3Qag4lkDF+ Cjno+o/bF+kqb2lFuyAWXqBTa+Vcz2r1QrPvNkmrS8Fo7XsSAXt9s91Di A==; X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="367087056" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="367087056" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:42:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="868274880" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.6.77]) ([10.93.6.77]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:42:09 -0700 Message-ID: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Date: Fri, 21 Jul 2023 23:42:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory Content-Language: en-US From: Xiaoyao Li To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , linux-security-module@vger.kernel.org, Wang , Fuad Tabba , Maciej Szmigiero , Michael Roth , Ackerley Tng , kvmarm@lists.linux.dev, Vlastimil Babka , linux-arm-kernel@lists.infradead.org, Quentin Perret , linux-mips@vger.kernel.org, Jarkko Sakkinen , Yu Zhang , kvm-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, Liam Merwick , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, "Kirill A . Shutemov" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 7/21/2023 11:05 PM, Xiaoyao Li wrote: > On 7/19/2023 7:44 AM, Sean Christopherson wrote: >> @@ -6255,12 +6298,17 @@ int kvm_init(unsigned vcpu_size, unsigned >> vcpu_align, struct module *module) >>       if (r) >>           goto err_async_pf; >> +    r = kvm_gmem_init(); >> +    if (r) >> +        goto err_gmem; >> + >>       kvm_chardev_ops.owner = module; >>       kvm_preempt_ops.sched_in = kvm_sched_in; >>       kvm_preempt_ops.sched_out = kvm_sched_out; >>       kvm_init_debug(); >> +    kvm_gmem_init(); > > why kvm_gmem_init() needs to be called again? by mistake? I'm sure it's a mistake. I'm testing the gmem QEMU with this series. SW_PROTECTED_VM gets stuck in a loop in early OVMF code due to two shared page of OVMF get zapped and re-mapped infinitely. Removing the second call of kvm_gmem_init() can solve the issue, though I'm not sure about the reason.