From: "Li Yang" <leoli@freescale.com>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: dbrownell@users.sourceforge.net, greg@kroah.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver
Date: Wed, 3 Sep 2008 11:51:39 +0800 [thread overview]
Message-ID: <2a27d3730809022051p73cdfe92sde02996c6f22db9b@mail.gmail.com> (raw)
In-Reply-To: <200809021401.25506.arnd@arndb.de>
On Tue, Sep 2, 2008 at 8:01 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 02 September 2008, Li Yang wrote:
>> Some of Freescale SoC chips have a QE or CPM co-processor which
>> supports full speed USB. The driver adds device mode support
>> of both QE and CPM USB controller to Linux USB gadget. The
>> driver is tested with MPC8360 and MPC8272, and should work with
>> other models having QE/CPM given minor tweaks.
>>
>> Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
>> Signed-off-by: Li Yang <leoli@freescale.com>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> All my previous review comments have been addressed.
>
>> + udc_controller->soc_type = (unsigned long)np->data;
>
> I'm not sure about this line, shouldn't that be
> udc_controller->soc_type = (unsigned long)match->data; ?
Oops. You are right.
- Leo
prev parent reply other threads:[~2008-09-03 3:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 11:58 [PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver Li Yang
2008-09-02 12:01 ` Arnd Bergmann
2008-09-03 3:51 ` Li Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a27d3730809022051p73cdfe92sde02996c6f22db9b@mail.gmail.com \
--to=leoli@freescale.com \
--cc=arnd@arndb.de \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).