From: "Li Yang" <leoli@freescale.com>
To: "Timur Tabi" <timur@freescale.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
Andy Fleming <afleming@freescale.com>,
Jeff Garzik <jgarzik@pobox.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 6/6] ucc_geth: Remove UGETH_FILTERING dead code
Date: Mon, 22 Dec 2008 19:13:43 +0800 [thread overview]
Message-ID: <2a27d3730812220313w5882edb8nf7c2978cd0dcac5f@mail.gmail.com> (raw)
In-Reply-To: <ed82fe3e0812201923s7ff3401i2d12aca4ae9de1e7@mail.gmail.com>
On Sun, Dec 21, 2008 at 11:23 AM, Timur Tabi <timur@freescale.com> wrote:
> On Thu, Dec 18, 2008 at 12:23 PM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
>> The code appears to be dead: nobody call these functions, plus build
>> breaks when UGETH_FILTERING is enabled:
>
> I general, I agree with patches like this, but I'd like to hear from
> Leo first why this code was written in the first place before I can
> ack it.
The code was there to test the frame filtering feature which probably
can be used in multicast and VLAN support. I didn't remove it because
it could be a base for whoever interested to implement a general frame
filtering framework or custom features. Given the fact that unused
code can easily become broken. I agree that it can be removed for
now.
Acked-by: Li Yang <leoli@freescale.com>
prev parent reply other threads:[~2008-12-22 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 18:23 [PATCH 6/6] ucc_geth: Remove UGETH_FILTERING dead code Anton Vorontsov
2008-12-21 3:23 ` Timur Tabi
2008-12-22 11:13 ` Li Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a27d3730812220313w5882edb8nf7c2978cd0dcac5f@mail.gmail.com \
--to=leoli@freescale.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).