Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

[Li Yang <leoli@freescale.com>]

On Mon, Jan 12, 2009 at 11:07 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Jan 12, 2009, at 1:55 AM, Li Yang wrote:
>
>>> -----Original Message-----
>>> From: linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org
>>> [mailto:linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org]
>>> On Behalf Of Anton Vorontsov
>>> Sent: Sunday, January 11, 2009 11:30 PM
>>> To: Kumar Gala
>>> Cc: linuxppc-dev@ozlabs.org
>>> Subject: [PATCH] powerpc/83xx: Make serial ports work on
>>> MPC8315E-RDB w/FSL U-Boots
>>>
>>> FSL U-Boots use /soc8315@e0000000 node to search and fixup
>>> serial nodes' clock-frequency properties. Though in upstream
>>> kernels we use new naming convention -- for IMMR address
>>> space dts files specify /immr@e0000000 nodes.
>>>
>>> This makes FSL U-Boots fail to fixup the clock frequencies,
>>> and that leads to serial ports misbehaviour. We can
>>> workaround the issue by filling the clock frequency values manually.
>>
>> Freescale BSP is for customer who needs the out-of-box experience.  It's
>> better tested, but doesn't update very frequently.  I would suggest the
>> customer to use the upstream u-boot, if they decide to use latest
>> upstream kernel.
>>
>> - Leo
>
> Agreed.  However I don't think there is any harm w/the patch as upstream
> u-boot will update the property.

You are right.   There will be no harm as upstream u-boot can update
the DTS of old binding.

- Leo