linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots
@ 2009-01-11 15:30 Anton Vorontsov
  2009-01-12  7:55 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots Li Yang
  2009-01-12 15:10 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Kumar Gala
  0 siblings, 2 replies; 7+ messages in thread
From: Anton Vorontsov @ 2009-01-11 15:30 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev

FSL U-Boots use /soc8315@e0000000 node to search and fixup serial
nodes' clock-frequency properties. Though in upstream kernels we use
new naming convention -- for IMMR address space dts files specify
/immr@e0000000 nodes.

This makes FSL U-Boots fail to fixup the clock frequencies, and that
leads to serial ports misbehaviour. We can workaround the issue by
filling the clock frequency values manually.

p.s. For the same reason FSL U-Boots fail to fixup MAC addresses for
ethernet nodes, so users should either change the .dts file locally
or set MAC address via `ifconfig hw ether' command.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---

Leon,

With this patch 2.6.28 kernel boots and works fine with the U-Boot
I took from this image (downloadable from freescale.com):

$ md5sum MPC8315ERDB_20080321-ltib.iso
009730826366d593347b88fa4fdb9be0  MPC8315ERDB_20080321-ltib.iso

That is, U-Boot 1.3.0-rc2 (Mar 21 2008 - 13:36:09) MPC83XX

 arch/powerpc/boot/dts/mpc8315erdb.dts |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/boot/dts/mpc8315erdb.dts
index 9a4fa2a..88d691c 100644
--- a/arch/powerpc/boot/dts/mpc8315erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
@@ -257,7 +257,7 @@
 			device_type = "serial";
 			compatible = "ns16550";
 			reg = <0x4500 0x100>;
-			clock-frequency = <0>;
+			clock-frequency = <133333333>;
 			interrupts = <9 0x8>;
 			interrupt-parent = <&ipic>;
 		};
@@ -267,7 +267,7 @@
 			device_type = "serial";
 			compatible = "ns16550";
 			reg = <0x4600 0x100>;
-			clock-frequency = <0>;
+			clock-frequency = <133333333>;
 			interrupts = <10 0x8>;
 			interrupt-parent = <&ipic>;
 		};
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* RE: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots
  2009-01-11 15:30 [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Anton Vorontsov
@ 2009-01-12  7:55 ` Li Yang
  2009-01-12 15:07   ` Kumar Gala
  2009-01-12 15:10 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Kumar Gala
  1 sibling, 1 reply; 7+ messages in thread
From: Li Yang @ 2009-01-12  7:55 UTC (permalink / raw)
  To: Anton Vorontsov, Kumar Gala; +Cc: linuxppc-dev

> -----Original Message-----
> From: linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org=20
> [mailto:linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org]=20
> On Behalf Of Anton Vorontsov
> Sent: Sunday, January 11, 2009 11:30 PM
> To: Kumar Gala
> Cc: linuxppc-dev@ozlabs.org
> Subject: [PATCH] powerpc/83xx: Make serial ports work on=20
> MPC8315E-RDB w/FSL U-Boots
>=20
> FSL U-Boots use /soc8315@e0000000 node to search and fixup=20
> serial nodes' clock-frequency properties. Though in upstream=20
> kernels we use new naming convention -- for IMMR address=20
> space dts files specify /immr@e0000000 nodes.
>=20
> This makes FSL U-Boots fail to fixup the clock frequencies,=20
> and that leads to serial ports misbehaviour. We can=20
> workaround the issue by filling the clock frequency values manually.

Freescale BSP is for customer who needs the out-of-box experience.  It's
better tested, but doesn't update very frequently.  I would suggest the
customer to use the upstream u-boot, if they decide to use latest
upstream kernel.

- Leo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots
  2009-01-12  7:55 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots Li Yang
@ 2009-01-12 15:07   ` Kumar Gala
  2009-01-12 17:20     ` Leon Woestenberg
  2009-01-13  5:52     ` Li Yang
  0 siblings, 2 replies; 7+ messages in thread
From: Kumar Gala @ 2009-01-12 15:07 UTC (permalink / raw)
  To: Li Yang; +Cc: linuxppc-dev


On Jan 12, 2009, at 1:55 AM, Li Yang wrote:

>> -----Original Message-----
>> From: linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org
>> [mailto:linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org]
>> On Behalf Of Anton Vorontsov
>> Sent: Sunday, January 11, 2009 11:30 PM
>> To: Kumar Gala
>> Cc: linuxppc-dev@ozlabs.org
>> Subject: [PATCH] powerpc/83xx: Make serial ports work on
>> MPC8315E-RDB w/FSL U-Boots
>>
>> FSL U-Boots use /soc8315@e0000000 node to search and fixup
>> serial nodes' clock-frequency properties. Though in upstream
>> kernels we use new naming convention -- for IMMR address
>> space dts files specify /immr@e0000000 nodes.
>>
>> This makes FSL U-Boots fail to fixup the clock frequencies,
>> and that leads to serial ports misbehaviour. We can
>> workaround the issue by filling the clock frequency values manually.
>
> Freescale BSP is for customer who needs the out-of-box experience.   
> It's
> better tested, but doesn't update very frequently.  I would suggest  
> the
> customer to use the upstream u-boot, if they decide to use latest
> upstream kernel.
>
> - Leo

Agreed.  However I don't think there is any harm w/the patch as  
upstream u-boot will update the property.

- k

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots
  2009-01-11 15:30 [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Anton Vorontsov
  2009-01-12  7:55 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots Li Yang
@ 2009-01-12 15:10 ` Kumar Gala
  1 sibling, 0 replies; 7+ messages in thread
From: Kumar Gala @ 2009-01-12 15:10 UTC (permalink / raw)
  To: Anton Vorontsov; +Cc: linuxppc-dev


On Jan 11, 2009, at 9:30 AM, Anton Vorontsov wrote:

> FSL U-Boots use /soc8315@e0000000 node to search and fixup serial
> nodes' clock-frequency properties. Though in upstream kernels we use
> new naming convention -- for IMMR address space dts files specify
> /immr@e0000000 nodes.
>
> This makes FSL U-Boots fail to fixup the clock frequencies, and that
> leads to serial ports misbehaviour. We can workaround the issue by
> filling the clock frequency values manually.
>
> p.s. For the same reason FSL U-Boots fail to fixup MAC addresses for
> ethernet nodes, so users should either change the .dts file locally
> or set MAC address via `ifconfig hw ether' command.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>
> Leon,
>
> With this patch 2.6.28 kernel boots and works fine with the U-Boot
> I took from this image (downloadable from freescale.com):
>
> $ md5sum MPC8315ERDB_20080321-ltib.iso
> 009730826366d593347b88fa4fdb9be0  MPC8315ERDB_20080321-ltib.iso
>
> That is, U-Boot 1.3.0-rc2 (Mar 21 2008 - 13:36:09) MPC83XX
>
> arch/powerpc/boot/dts/mpc8315erdb.dts |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

applied

- k

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots
  2009-01-12 15:07   ` Kumar Gala
@ 2009-01-12 17:20     ` Leon Woestenberg
  2009-01-12 18:59       ` Kumar Gala
  2009-01-13  5:52     ` Li Yang
  1 sibling, 1 reply; 7+ messages in thread
From: Leon Woestenberg @ 2009-01-12 17:20 UTC (permalink / raw)
  To: Li Yang; +Cc: linuxppc-dev

Hello,

On Mon, Jan 12, 2009 at 4:07 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
> On Jan 12, 2009, at 1:55 AM, Li Yang wrote:
>>> -----Original Message-----
>> Freescale BSP is for customer who needs the out-of-box experience.  It's
>> better tested, but doesn't update very frequently.  I would suggest the
>> customer to use the upstream u-boot, if they decide to use latest
>> upstream kernel.
>>
>
The upstream u-boot did however not support PCI Express, which the
latest Freescale kernel did.

So it was a chicken-egg problem experience for people wanting to test
both the latest Freescale kernel as well as Antov's work to bring the
PCI Express support upstream.

Thanks Antov et al,
-- 
Leon

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots
  2009-01-12 17:20     ` Leon Woestenberg
@ 2009-01-12 18:59       ` Kumar Gala
  0 siblings, 0 replies; 7+ messages in thread
From: Kumar Gala @ 2009-01-12 18:59 UTC (permalink / raw)
  To: Leon Woestenberg; +Cc: linuxppc-dev, Li Yang


On Jan 12, 2009, at 11:20 AM, Leon Woestenberg wrote:

> Hello,
>
> On Mon, Jan 12, 2009 at 4:07 PM, Kumar Gala  
> <galak@kernel.crashing.org> wrote:
>> On Jan 12, 2009, at 1:55 AM, Li Yang wrote:
>>>> -----Original Message-----
>>> Freescale BSP is for customer who needs the out-of-box  
>>> experience.  It's
>>> better tested, but doesn't update very frequently.  I would  
>>> suggest the
>>> customer to use the upstream u-boot, if they decide to use latest
>>> upstream kernel.
>>>
>>
> The upstream u-boot did however not support PCI Express, which the
> latest Freescale kernel did.
>
> So it was a chicken-egg problem experience for people wanting to test
> both the latest Freescale kernel as well as Antov's work to bring the
> PCI Express support upstream.
>
> Thanks Antov et al,

Please gripe at your Freescale contacts about getting code into  
mainline/upstream kernel.

(The more they hear it from customers the more importance it will  
get.  The team I work on at Freescale can focus on only so much and  
the other groups need to hear that customers want code in mainline.)

And thanks Anton for cleaning all this up and getting it in a state  
that is acceptable :)

- k

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots
  2009-01-12 15:07   ` Kumar Gala
  2009-01-12 17:20     ` Leon Woestenberg
@ 2009-01-13  5:52     ` Li Yang
  1 sibling, 0 replies; 7+ messages in thread
From: Li Yang @ 2009-01-13  5:52 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev

On Mon, Jan 12, 2009 at 11:07 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Jan 12, 2009, at 1:55 AM, Li Yang wrote:
>
>>> -----Original Message-----
>>> From: linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org
>>> [mailto:linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org]
>>> On Behalf Of Anton Vorontsov
>>> Sent: Sunday, January 11, 2009 11:30 PM
>>> To: Kumar Gala
>>> Cc: linuxppc-dev@ozlabs.org
>>> Subject: [PATCH] powerpc/83xx: Make serial ports work on
>>> MPC8315E-RDB w/FSL U-Boots
>>>
>>> FSL U-Boots use /soc8315@e0000000 node to search and fixup
>>> serial nodes' clock-frequency properties. Though in upstream
>>> kernels we use new naming convention -- for IMMR address
>>> space dts files specify /immr@e0000000 nodes.
>>>
>>> This makes FSL U-Boots fail to fixup the clock frequencies,
>>> and that leads to serial ports misbehaviour. We can
>>> workaround the issue by filling the clock frequency values manually.
>>
>> Freescale BSP is for customer who needs the out-of-box experience.  It's
>> better tested, but doesn't update very frequently.  I would suggest the
>> customer to use the upstream u-boot, if they decide to use latest
>> upstream kernel.
>>
>> - Leo
>
> Agreed.  However I don't think there is any harm w/the patch as upstream
> u-boot will update the property.

You are right.   There will be no harm as upstream u-boot can update
the DTS of old binding.

- Leo

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-01-13  5:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-11 15:30 [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Anton Vorontsov
2009-01-12  7:55 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots Li Yang
2009-01-12 15:07   ` Kumar Gala
2009-01-12 17:20     ` Leon Woestenberg
2009-01-12 18:59       ` Kumar Gala
2009-01-13  5:52     ` Li Yang
2009-01-12 15:10 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).