From: Li Yang <leoli@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org,
Joakim Tjernlund <Joakim.Tjernlund@transmode.se>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ucc_geth: Rework the TX logic.
Date: Tue, 31 Mar 2009 16:16:58 +0800 [thread overview]
Message-ID: <2a27d3730903310116r4d8602b8y41e466801bbb8d3e@mail.gmail.com> (raw)
In-Reply-To: <49D0FFBB.7000009@freescale.com>
On Tue, Mar 31, 2009 at 1:22 AM, Scott Wood <scottwood@freescale.com> wrote=
:
> Joakim Tjernlund wrote:
>>
>> gianfar does not seem to use in_/out_ functions for the BDs. Works just
>> fine that too it seems.
>
> It does now that it has explicit barriers in a few places. =C2=A0Before t=
hey were
> added, it would sometimes fail under load. =C2=A0That was due to a compil=
er
> reordering, but CPU reordering was possible as well.
I noticed that in gianfar these memory access is not protected by
"volatile". Can this be the reason why the compiler did some unwanted
optimization?
- Leo
prev parent reply other threads:[~2009-03-31 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 17:44 [PATCH] ucc_geth: Rework the TX logic Joakim Tjernlund
2009-03-26 18:03 ` Anton Vorontsov
2009-03-26 18:26 ` Joakim Tjernlund
2009-03-27 9:45 ` Li Yang
2009-03-27 10:23 ` Joakim Tjernlund
2009-03-27 10:39 ` Li Yang
2009-03-27 11:39 ` Joakim Tjernlund
2009-03-27 13:26 ` Scott Wood
2009-03-30 16:38 ` Joakim Tjernlund
2009-03-30 17:22 ` Scott Wood
2009-03-30 17:34 ` Joakim Tjernlund
2009-03-30 17:45 ` Scott Wood
2009-03-30 18:42 ` Joakim Tjernlund
2009-03-30 19:32 ` Scott Wood
2009-03-31 9:07 ` Joakim Tjernlund
2009-03-31 10:58 ` Li Yang
2009-03-31 14:37 ` Scott Wood
2009-03-31 8:16 ` Li Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a27d3730903310116r4d8602b8y41e466801bbb8d3e@mail.gmail.com \
--to=leoli@freescale.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).