linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Li Yang <leoli@freescale.com>
To: hs@denx.de
Cc: Shlomi Gridish <gridish@freescale.com>,
	netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode
Date: Tue, 21 Apr 2009 18:51:11 +0800	[thread overview]
Message-ID: <2a27d3730904210351s870f015gb896a4b874b3024b@mail.gmail.com> (raw)
In-Reply-To: <49ED859B.30904@denx.de>

On Tue, Apr 21, 2009 at 4:36 PM, Heiko Schocher <hs@denx.de> wrote:
> If using the UCC on a MPC8360 in RMII mode, don;t set
> UCC_GETH_UPSMR_RPM bit in the upsmr register.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>

Acked-by: Li Yang <leoli@freescale.com>

> ---
> =C2=A0drivers/net/ucc_geth.c | =C2=A0 =C2=A03 ++-
> =C2=A01 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
> index d3f39e8..44f8392 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -1394,7 +1394,8 @@ static int adjust_enet_interface(struct ucc_geth_pr=
ivate *ugeth)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(ugeth->phy_interface =3D=3D PHY=
_INTERFACE_MODE_RGMII_RXID) ||
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(ugeth->phy_interface =3D=3D PHY=
_INTERFACE_MODE_RGMII_TXID) ||
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(ugeth->phy_interface =3D=3D PHY=
_INTERFACE_MODE_RTBI)) {
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 upsmr |=3D UCC_GETH_UP=
SMR_RPM;
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ugeth->phy_interfa=
ce !=3D PHY_INTERFACE_MODE_RMII)
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 upsmr |=3D UCC_GETH_UPSMR_RPM;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0switch (ugeth->max=
_speed) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case SPEED_10:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0upsmr |=3D UCC_GETH_UPSMR_R10M;

  reply	other threads:[~2009-04-21 10:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21  8:36 [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode Heiko Schocher
2009-04-21 10:51 ` Li Yang [this message]
2009-04-22  7:46   ` David Miller
2009-04-21 11:22 ` Gridish Shlomi-RM96313

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a27d3730904210351s870f015gb896a4b874b3024b@mail.gmail.com \
    --to=leoli@freescale.com \
    --cc=gridish@freescale.com \
    --cc=hs@denx.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).