From: Segher Boessenkool <segher@kernel.crashing.org>
To: Wade Farnsworth <wfarnsworth@mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH] When checking I8042 io port, use of_find_compatible_node() instead of of_find_node_by_type()
Date: Thu, 7 Jun 2007 15:05:51 +0200 [thread overview]
Message-ID: <2a56a9d008269d393c68959f1804c21d@kernel.crashing.org> (raw)
In-Reply-To: <1181148145.5674.121.camel@rhino>
> In check_legacy_ioport(), instead of using of_find_node_by_type() to
> find the 8042 node, use of_find_compatible_node() to find either the
> keyboard or mouse node.
Why?
> switch(base_port) {
> case I8042_DATA_REG:
> - np = of_find_node_by_type(NULL, "8042");
> + np = of_find_compatible_node(NULL, NULL, "pnpPNP,303");
> + if (!np)
> + np = of_find_compatible_node(NULL, NULL, "pnpPNP,f03");
> + if (np) {
> + parent = of_get_parent(np);
> + of_node_put(np);
> + np = parent;
> + }
This breaks other boards using 8042, if those exist --
if this code is board-specific, it is in the wrong file.
Segher
next prev parent reply other threads:[~2007-06-07 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 16:42 [PATCH] When checking I8042 io port, use of_find_compatible_node() instead of of_find_node_by_type() Wade Farnsworth
2007-06-07 13:05 ` Segher Boessenkool [this message]
2007-06-07 16:26 ` Wade Farnsworth
2007-06-07 16:59 ` Segher Boessenkool
2007-06-07 17:52 ` Wade Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a56a9d008269d393c68959f1804c21d@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=wfarnsworth@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).