From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08460EB64D7 for ; Wed, 21 Jun 2023 23:24:30 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=tBqvzi0B; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qmfj91Btgz3bt2 for ; Thu, 22 Jun 2023 09:24:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=tBqvzi0B; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=jlayton@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QmZ0x02hxz303p; Thu, 22 Jun 2023 05:52:48 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2B69616B0; Wed, 21 Jun 2023 19:52:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89C99C433C8; Wed, 21 Jun 2023 19:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687377165; bh=vTL4Y8a8sFEsX3Xqt4OIZCRU2/7UfNvPDdjp0N/3dJE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=tBqvzi0BueVyLSEbesqZv6Z2lEPP3VHDK/0ro+NhJgrWCN7POU/GnsfWmg+au/I1/ qhi//1NZGnRyBWC+DfSRBIODYBQomanDaEsbNql7Uti143OqrGRxW4LYitKm3HOUFm 3AFCsCq6C4olFaFCKGiCtIGy0tLgZnX0NusQlw4HgjVra9Ac5A8Ylg7+9/P0lUpR5a +VLBtjm16h891O76lVM1Ta8bhTOaRz+hamckCGdfcbzLfSMEYWZEagHpIq+7Dm+VlU f0RFgH+s7zmUzeMyOo6a8vBaboDD6pPbvwZcf5WIVyOhAezSg+L8WY3I+kat7Le9is Pb20wj8vyk/yg== Message-ID: <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org> Subject: Re: [PATCH 00/79] fs: new accessors for inode->i_ctime From: Jeff Layton To: Steven Rostedt Date: Wed, 21 Jun 2023 15:52:27 -0400 In-Reply-To: <20230621152141.5961cf5f@gandalf.local.home> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621152141.5961cf5f@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 22 Jun 2023 09:22:21 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , "Rafael J. Wysocki" , "Darrick J. Wong" , Anders Larsen , Carlos Llamas , Andrii Nakryiko , Hugh Dickins , John Johansen , Seth Forshee , Alexander Gordeev , Christoph Hellwig , Mike Marshall , Paulo Alcantara , linux-xfs@vger.kernel.org, Bart Van Assche , John Keeping , Zhang Yi , James Morris , Tyler Hicks , Alan Stern , Christian Borntraeger , devel@lists.orangefs.org, Shyam Prasad N , Jan Harkes , linux-um@lists.infradead.org, Nicholas Piggin , Alexander Viro , Eric Van Hensbergen , Suren Baghdasaryan , Trond Myklebust , Anton Altaparmakov , Christian Brauner , Wolfram Sang , Greg Kroah-Hartman , Stephen Smalley , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ronnie Sahlberg , Sergey Senozhatsky , Luis Chamberlain , Chuck Lever , Sven Schnelle , Jiri Olsa , Jan Kara , Tejun Heo , Andrew Morton , linux-trace-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Dave Kleikamp , Sandeep Dhavale , Tetsuo Handa , Mimi Zohar , linux-mm@kvack.org, Joel Fernandes , Eric Dumazet , Stanislav Fomichev , Andrzej Pietrasiewicz , Hangyu Hua , linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, Paul Moore , Leon Romanovsky , John Fastabend , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Minghao Chi , codalist@coda.cs.cmu.edu, selinux@vger.kernel.org, ZhangPeng , Udipto Goswami , Yonghong Song , Iurii Zaikin , Namjae Jeon , Masami Hiramatsu , ecryptfs@vger.kernel.org, Todd Kjos , Vasily Gorbik , Yu Zhe , linuxppc-dev@lists.ozlabs.org, reiserfs-devel@vger.kernel.org, Miklos Szeredi , Yue Hu , Jaegeuk Kim , Aditya Garg , Martijn Coenen , OGAWA Hirofumi , Hao Luo , Tony Luck , Theodore Ts'o , Nicolas Pitre , linux-ntfs-dev@lists.sourceforge.net, Muchun Song , Roberto Sassu , linux-f2fs-devel@lists.sourceforge.net, "Guilherme G. Piccoli" , Jozef Martiniak , Eric Biederman , Anna Schumaker , xu xin , Brad Warrum , Mike Kravetz , Jingyu Wang , linux-efi@vger.kernel.org, Dan Carpenter , Martin Brandenburg , Tom Rix , Alexei Starovoitov , Chris Mason , linux-mtd@lists.infradead.org, "Matthew Wilcox \(Oracle\)" , Marc Dionne , linux-afs@lists.infradead.org, Ian Kent , Naohiro Aota , Daniel Borkmann , Dennis Dalessandro , linux-rdma@vger.kernel.org, Linyu Yuan , coda@cs.cmu.edu, Viacheslav Dubeyko , Ilya Dryomov , Paolo Abeni , Alexey Dobriyan , "Serge E. Hallyn" , Zhihao Cheng , Jens Axboe , Zeng Jingxiang , Kees Cook , Arnd Bergmann , autofs@vger.kernel.org, Yifei Liu , Damien Le Moal , Eric Paris , ceph-devel@vger.kernel.org, Gao Xiang , Jiangshan Yi , David Howells , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, Song Liu , samba-technical@lists.samba.org, Steve French , Jeremy Kerr , netdev@vger.kernel.org, Bob Peterson , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, ntfs3@lists.linux.dev, linux-erofs@lists.ozlabs.org, "David S. Miller" , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Dominique Martinet , Christian Schoenebeck , Bob Copeland , KP Singh , Oleg Kanatov , Konstantin Komarov , Joseph Qi , Yuta Hayama , Andreas Dilger , Mikulas Patocka , Zhengchao Shao , Chen Zhongjin , Ard Biesheuvel , Anton Ivanov , Laurent Pinchart , Andreas Gruenbacher , Richard Weinberger , Mark Fasheh , Stefan Roesch , cluster-devel@redhat.com, Jason Gunthorpe , Jakub Kicinski , Rik van Riel , Salah Triki , Evgeniy Dushistov , linux-cifs@vger.kernel.org, Heiko Carstens , Chao Yu , apparmor@lists.ubuntu.com, Josef Bacik , "Liam R. Howlett" , Tom Talpey , Hans de Goede , "Tigran A. Aivazian" , Dave Chinner , David Sterba , Xiubo Li , Ryusuke Konishi , Juergen Gross , Johannes Thumshirn , Ritu Agarwal , Luis de Bethencourt , Martin KaFai Lau , v9fs@lists.linux.dev, "Fabio M. De Francesco" , linux-unionfs@vger.kernel.org, Ruihan Li , linux-security-module@vger.kernel.org, Erez Zadok , Jeffle Xu , "Dr. David Alan Gilbert" , Johannes Weiner , Phillip Lougher , Johannes Berg , Sungjong Seo , David Woodhouse , linux-karma-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, Joel Becker Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton wrote: >=20 > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set. That will come later, as we convert individual > > filesystems to use multigrain timestamps. >=20 > BTW, Linus has suggested to me that whenever a conccinelle script is used= , > it should be included in the change log. >=20 Ok, here's what I have. I note again that my usage of coccinelle is pretty primitive, so I ended up doing a fair bit of by-hand fixing after applying these. Given the way that this change is broken up into 77 patches by subsystem, to which changelogs should I add it? I could add it to the "infrastructure" patch, but that's the one where I _didn't_ use it.=A0 Maybe to patch #79 (the one that renames i_ctime)? ------------------------8<------------------------------ @@ expression inode; @@ - inode->i_ctime =3D current_time(inode) + inode_set_current_ctime(inode) @@ expression inode; @@ - inode->i_ctime =3D inode->i_mtime =3D current_time(inode) + inode->i_mtime =3D inode_set_current_ctime(inode) @@ struct inode *inode; expression value; @@ - inode->i_ctime =3D value; + inode_set_ctime(inode, value); @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_sec =3D val + inode_set_ctime_sec(inode, val) @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_nsec =3D val + inode_set_ctime_nsec(inode, val) @@ struct inode *inode; @@ - inode->i_ctime + inode_ctime_peek(inode)