linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Yoder Stuart <stuart.yoder@freescale.com>
Subject: Re: dtc: Add some documentation for the dts formta
Date: Tue, 11 Mar 2008 19:50:11 +0100	[thread overview]
Message-ID: <2ad5f1b8f63afd9e32a25175d1b0b5e0@kernel.crashing.org> (raw)
In-Reply-To: <20080310234714.GB11559@localhost.localdomain>

> This patch adds a dts-format.txt in the Documentation directory, with
> an introduction to the dtc source format.

Looks good, some minor nits...

> +* A 64-bit value is represented with two 32-bit cells.
> +
> +	e.g. clock-frequency = <0x00000001 0x00000000>;

Please add that this is big-endian order always.

> +* Values may have several comma-separated components, which are
> +  concatenated together.
> +	e.g. compatible = "ns16550", "ns8250";

You might want to clarify that the terminating 0 of ns16550 becomes
part of the property, i.e. this is not like strcat() in C.


Segher

      parent reply	other threads:[~2008-03-11 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 23:47 dtc: Add some documentation for the dts formta David Gibson
2008-03-11 15:34 ` Yoder Stuart
2008-03-11 18:50 ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ad5f1b8f63afd9e32a25175d1b0b5e0@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).