LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Nicholas Piggin <npiggin@gmail.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Is unrecoverable_exception() really an interrupt handler ?
Date: Wed, 24 Feb 2021 09:15:37 +0100	[thread overview]
Message-ID: <2b89ac7e-e971-7de6-e6af-4bd86b699eab@csgroup.eu> (raw)

Hi Nick,

You defined unrecoverable_exeption() as an interrupt handler in interrupt.h

I think there are several issues around that:

- do_bad_slb_fault() which is also an interrupt handler calls unrecoverable_exeption()
- in exception-64s.S, unrecoverable_exeption() is called after machine_check_exception()
- interrupt_exit_kernel_prepare() calls unrecoverable_exception()

So in those cases, interrupt_enter_prepare() gets called twice, so things like for instance 
account_cpu_user_entry() gets called twice.

Christophe

             reply	other threads:[~2021-02-24  8:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  8:15 Christophe Leroy [this message]
2021-02-25 10:54 ` Is unrecoverable_exception() really an interrupt handler ? Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b89ac7e-e971-7de6-e6af-4bd86b699eab@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox