From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 80D88DDE1F for ; Sun, 29 Jun 2008 09:37:35 +1000 (EST) In-Reply-To: References: <20080627115243.d76e0814.kim.phillips@freescale.com> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <2b97f7566925ed86b78b364ff5724644@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH v2] update crypto node definition and device tree instances Date: Sun, 29 Jun 2008 01:37:12 +0200 To: "Grant Likely" Cc: linuxppc-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > I'm really don't like "fsl,sec1.0" or any of the variants as a > compatible property either because it can easily be abused (it's not > anchored to a specific physical part so the meaning can shift over > time); but that is another argument and it is well documented in other > email threads > (http://thread.gmane.org/gmane.linux.ports.ppc64.devel/38977/ > focus=39147) Also, these made-up names make you do more work: you'll need to write up a binding for them, explaining exactly what a 1.0 device etc. is (or at least point to documentation for it). If you use a name that refers to some device that people can easily google for documentation, you can skip this (well, you might need to write a binding anyway; but at least you won't have to explain what the device _is_). Using actual model names also reduces the namespace pollution (hopefully Freescale will not create some other MPC8272 device ever, so "fsl,mpc8272-whatever" will never be a nice name to use for any other device; OTOH, it's likely that Freescale will create some other device called "SEC" (there are only so many TLAs, after all), so "fsl,sec-n.m" isn't as future-proof. Segher