linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>, hch@lst.de
Cc: linux-ia64@vger.kernel.org,
	James.Bottomley@HansenPartnership.com, paulus@samba.org,
	hpa@zytor.com, sparclinux@vger.kernel.org, sfr@canb.auug.org.au,
	deller@gmx.de, x86@kernel.org, borntraeger@de.ibm.com,
	mingo@redhat.com, mattst88@gmail.com, fenghua.yu@intel.com,
	gor@linux.ibm.com, linux-s390@vger.kernel.org, hca@linux.ibm.com,
	ink@jurassic.park.msu.ru, tglx@linutronix.de,
	gerald.schaefer@linux.ibm.com, rth@twiddle.net,
	tony.luck@intel.com, linux-parisc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	bp@alien8.de, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [PATCH 0/2] dma-mapping: update default segment_boundary_mask
Date: Wed, 2 Sep 2020 10:13:12 +0200	[thread overview]
Message-ID: <2c8db0aa-e8b5-e577-b971-1de10ecc6747@linux.ibm.com> (raw)
In-Reply-To: <20200901221646.26491-1-nicoleotsuka@gmail.com>



On 9/2/20 12:16 AM, Nicolin Chen wrote:
> These two patches are to update default segment_boundary_mask.
> 
> PATCH-1 fixes overflow issues in callers of dma_get_seg_boundary.
> Previous version was a series: https://lkml.org/lkml/2020/8/31/1026
> 
> Then PATCH-2 sets default segment_boundary_mask to ULONG_MAX.
> 
> Nicolin Chen (2):
>   dma-mapping: introduce dma_get_seg_boundary_nr_pages()
>   dma-mapping: set default segment_boundary_mask to ULONG_MAX

I gave both of your patches a quick test ride on a couple of dev mainframes,
both NVMe, ConnectX and virtio-pci devices all seems to work fine.
I already commented on Christoph's mail that I like the helper approach,
so as for s390 you can add my

Acked-by: Niklas Schnelle <schnelle@linux.ibm.com>

> 
>  arch/alpha/kernel/pci_iommu.c    |  7 +------
>  arch/ia64/hp/common/sba_iommu.c  |  3 +--
>  arch/powerpc/kernel/iommu.c      |  9 ++-------
>  arch/s390/pci/pci_dma.c          |  6 ++----
>  arch/sparc/kernel/iommu-common.c | 10 +++-------
>  arch/sparc/kernel/iommu.c        |  3 +--
>  arch/sparc/kernel/pci_sun4v.c    |  3 +--
>  arch/x86/kernel/amd_gart_64.c    |  3 +--
>  drivers/parisc/ccio-dma.c        |  3 +--
>  drivers/parisc/sba_iommu.c       |  3 +--
>  include/linux/dma-mapping.h      | 21 ++++++++++++++++++++-
>  11 files changed, 34 insertions(+), 37 deletions(-)
> 

  parent reply	other threads:[~2020-09-02  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 22:16 [PATCH 0/2] dma-mapping: update default segment_boundary_mask Nicolin Chen
2020-09-01 22:16 ` [PATCH 1/2] dma-mapping: introduce dma_get_seg_boundary_nr_pages() Nicolin Chen
2020-09-03  3:47   ` Michael Ellerman
2020-09-03 10:57   ` Andy Shevchenko
2020-09-03 16:12     ` Christoph Hellwig
2020-09-03 17:53       ` Christophe Leroy
2020-09-01 22:16 ` [PATCH 2/2] dma-mapping: set default segment_boundary_mask to ULONG_MAX Nicolin Chen
2020-09-02  8:13 ` Niklas Schnelle [this message]
2020-09-03  3:26   ` [PATCH 0/2] dma-mapping: update default segment_boundary_mask Nicolin Chen
2020-09-03 16:13   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c8db0aa-e8b5-e577-b971-1de10ecc6747@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=borntraeger@de.ibm.com \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=fenghua.yu@intel.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mattst88@gmail.com \
    --cc=mingo@redhat.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=paulus@samba.org \
    --cc=rth@twiddle.net \
    --cc=sfr@canb.auug.org.au \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).