* [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root
@ 2019-05-03 7:44 Andrew Donnellan
2019-05-03 7:48 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Donnellan @ 2019-05-03 7:44 UTC (permalink / raw)
To: linuxppc-dev; +Cc: stable, Stewart Smith, Jordan Niethe
Currently the OPAL symbol map is globally readable, which seems bad as it
contains physical addresses.
Restrict it to root.
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: Jordan Niethe <jniethe5@gmail.com>
Cc: Stewart Smith <stewart@linux.ibm.com>
Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map")
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
arch/powerpc/platforms/powernv/opal.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 2b0eca104f86..505460a72052 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -681,7 +681,10 @@ static ssize_t symbol_map_read(struct file *fp, struct kobject *kobj,
bin_attr->size);
}
-static BIN_ATTR_RO(symbol_map, 0);
+static struct bin_attribute symbol_map_attr = {
+ .attr = {.name = "symbol_map", .mode = 0400},
+ .read = symbol_map_read
+};
static void opal_export_symmap(void)
{
@@ -698,10 +701,10 @@ static void opal_export_symmap(void)
return;
/* Setup attributes */
- bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0]));
- bin_attr_symbol_map.size = be64_to_cpu(syms[1]);
+ symbol_map_attr.private = __va(be64_to_cpu(syms[0]));
+ symbol_map_attr.size = be64_to_cpu(syms[1]);
- rc = sysfs_create_bin_file(opal_kobj, &bin_attr_symbol_map);
+ rc = sysfs_create_bin_file(opal_kobj, &symbol_map_attr);
if (rc)
pr_warn("Error %d creating OPAL symbols file\n", rc);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root
2019-05-03 7:44 [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root Andrew Donnellan
@ 2019-05-03 7:48 ` Greg KH
2019-05-03 7:52 ` Andrew Donnellan
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-05-03 7:48 UTC (permalink / raw)
To: Andrew Donnellan; +Cc: linuxppc-dev, stable, Stewart Smith, Jordan Niethe
On Fri, May 03, 2019 at 05:44:05PM +1000, Andrew Donnellan wrote:
> Currently the OPAL symbol map is globally readable, which seems bad as it
> contains physical addresses.
>
> Restrict it to root.
>
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Jordan Niethe <jniethe5@gmail.com>
> Cc: Stewart Smith <stewart@linux.ibm.com>
> Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
> arch/powerpc/platforms/powernv/opal.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index 2b0eca104f86..505460a72052 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -681,7 +681,10 @@ static ssize_t symbol_map_read(struct file *fp, struct kobject *kobj,
> bin_attr->size);
> }
>
> -static BIN_ATTR_RO(symbol_map, 0);
> +static struct bin_attribute symbol_map_attr = {
> + .attr = {.name = "symbol_map", .mode = 0400},
> + .read = symbol_map_read
> +};
>
> static void opal_export_symmap(void)
> {
> @@ -698,10 +701,10 @@ static void opal_export_symmap(void)
> return;
>
> /* Setup attributes */
> - bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0]));
> - bin_attr_symbol_map.size = be64_to_cpu(syms[1]);
> + symbol_map_attr.private = __va(be64_to_cpu(syms[0]));
no tab?
checkpatch.pl is your friend :)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root
2019-05-03 7:48 ` Greg KH
@ 2019-05-03 7:52 ` Andrew Donnellan
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2019-05-03 7:52 UTC (permalink / raw)
To: Greg KH; +Cc: linuxppc-dev, stable, Stewart Smith, Jordan Niethe
On 3/5/19 5:48 pm, Greg KH wrote:
> no tab?
>
> checkpatch.pl is your friend :)
>
Ughhhhhhhhhh.
Sadly our CI is currently down ;)
Respun.
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-03 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-03 7:44 [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root Andrew Donnellan
2019-05-03 7:48 ` Greg KH
2019-05-03 7:52 ` Andrew Donnellan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).