From: Segher Boessenkool <segher@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: MPC83xx SDMR setup error
Date: Tue, 27 Mar 2007 00:53:42 +0200 [thread overview]
Message-ID: <2cf7d4ce28b4db08cd9ede0eeded130a@kernel.crashing.org> (raw)
In-Reply-To: <DD2F76DD-4427-4182-B17A-B470CF14E41D@kernel.crashing.org>
> Can you send this with a more proper header/subject and Signed-off-
> by, according to Documentation/SubmittingPatches
>> - out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK | (0x1 >>
>> + out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK | (0x1 <<
>> QE_SDMR_CEN_SHIFT)));
When you resend, please change the line break to
something more reasonable too (like, at the | sign) --
it might have avoided this bug in the first place.
Segher
next prev parent reply other threads:[~2007-03-26 22:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 14:30 MPC83xx SDMR setup error Chuck Meade
2007-03-22 16:13 ` Kumar Gala
2007-03-22 17:30 ` Chuck Meade
2007-03-22 17:57 ` Kim Phillips
2007-03-22 18:13 ` Chuck Meade
2007-03-26 20:10 ` Kumar Gala
2007-03-26 22:53 ` Segher Boessenkool [this message]
2007-03-27 0:22 ` Chuck Meade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cf7d4ce28b4db08cd9ede0eeded130a@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).