From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Eric Badger <ebadger@purestorage.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Oliver OHalloran <oohall@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] PCI/AER: Handle Multi UnCorrectable/Correctable errors properly
Date: Tue, 15 Mar 2022 10:26:46 -0700 [thread overview]
Message-ID: <2d4e8811-dce6-c891-e92d-e3746434685e@linux.intel.com> (raw)
In-Reply-To: <20220315171425.GA1521135@ebps>
On 3/15/22 10:14 AM, Eric Badger wrote:
>> # Prep injection data for a correctable error.
>> $ cd /sys/kernel/debug/apei/einj
>> $ echo 0x00000040 > error_type
>> $ echo 0x4 > flags
>> $ echo 0x891000 > param4
>>
>> # Root Error Status is initially clear
>> $ setpci -s <Dev ID> ECAP0001+0x30.w
>> 0000
>>
>> # Inject one error
>> $ echo 1 > error_inject
>>
>> # Interrupt received
>> pcieport <Dev ID>: AER: Root Error Status 0001
>>
>> # Inject another error (within 5 seconds)
>> $ echo 1 > error_inject
>>
>> # No interrupt received, but "multiple ERR_COR" is now set
>> $ setpci -s <Dev ID> ECAP0001+0x30.w
>> 0003
>>
>> # Wait for a while, then clear ERR_COR. A new interrupt immediately
>> fires.
>> $ setpci -s <Dev ID> ECAP0001+0x30.w=0x1
>> pcieport <Dev ID>: AER: Root Error Status 0002
>>
>> Currently, the above issue has been only reproduced in the ICL server
>> platform.
>>
>> [Eric: proposed reproducing steps]
> Hmm, this differs from the procedure I described on v1, and I don't
> think will work as described here.
I have attempted to modify the steps to reproduce it without returning
IRQ_NONE for all cases (which will break the functionality). But I
think I did not correct the last few steps.
How about replacing the last 3 steps with following?
# Inject another error (within 5 seconds)
$ echo 1 > error_inject
# You will get a new IRQ with only multiple ERR_COR bit set
pcieport <Dev ID>: AER: Root Error Status 0002
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2022-03-15 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 5:08 [PATCH v2] PCI/AER: Handle Multi UnCorrectable/Correctable errors properly Kuppuswamy Sathyanarayanan
2022-03-15 17:14 ` Eric Badger
2022-03-15 17:26 ` Sathyanarayanan Kuppuswamy [this message]
2022-03-15 19:52 ` Eric Badger
2022-03-15 21:29 ` Sathyanarayanan Kuppuswamy
2022-03-16 16:27 ` Eric Badger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d4e8811-dce6-c891-e92d-e3746434685e@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=ebadger@purestorage.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).