From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: R_PPC_ADDR16_HI relocs in PPC modules ?
Date: Wed, 3 Jan 2007 02:20:59 +0100 [thread overview]
Message-ID: <2d8333d72f58574b22339dfb29bc59a9@kernel.crashing.org> (raw)
In-Reply-To: <17818.64827.568060.143841@cargo.ozlabs.ibm.com>
>> Ah. lis and ori. HI16 is just fine there -- but note that
>> that doesn't use an add insn. You're patching the function
>
> lis is an addis with rA=0, don't forget...
Heh true. "I never forget that" ;-)
>> "apply_relocate_add()", so I guess some more work is needed?
>
> Looks fine as it is to me.
Looking at the bigger code, fine with me as well. Confusing
names are in the nature of this relocation stuff (esp. when
you start adding those ELF-defined "names").
Segher
next prev parent reply other threads:[~2007-01-03 1:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 16:25 R_PPC_ADDR16_HI relocs in PPC modules ? Simon Vallet
2007-01-02 17:16 ` Segher Boessenkool
2007-01-02 18:09 ` Simon Vallet
2007-01-02 20:48 ` Segher Boessenkool
2007-01-03 0:47 ` Paul Mackerras
2007-01-03 1:20 ` Segher Boessenkool [this message]
2007-01-02 20:41 ` Benjamin Herrenschmidt
2007-01-03 7:01 ` Simon Vallet
2007-01-03 9:58 ` Benjamin Herrenschmidt
2007-01-03 10:32 ` Simon Vallet
2007-01-03 20:36 ` Benjamin Herrenschmidt
2007-01-02 21:31 ` Alan Modra
2007-01-03 6:49 ` [PATCH] Add support for R_PPC_ADDR16_HI relocations Simon Vallet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d8333d72f58574b22339dfb29bc59a9@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).