From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1EAEC433B4 for ; Thu, 15 Apr 2021 08:25:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64CC361166 for ; Thu, 15 Apr 2021 08:25:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64CC361166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FLXV50d9Jz30Qk for ; Thu, 15 Apr 2021 18:25:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FrLbKiWI; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UJbcKBLM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=pbonzini@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FrLbKiWI; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UJbcKBLM; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FLXTY5cZNz2xyC for ; Thu, 15 Apr 2021 18:25:20 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618475115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bQmWZhJFBGurEcgsfC0EuOHiXGG/UZMr42BKHCg0CM=; b=FrLbKiWI78+iV+MeIABfx+K9zAaRG/DDZJY6QU8LGlMryR2JBVkthmbJWj0GSj+fyfxu1w kCoD4Jofj26FBTwiLgkIoqTirJOGbYiH9fKKAYiCJPDTeOJ2CR423ZNrzaFetgEubFODyr RsvI7E0cksB0klAXaN6FDIZrz35Z4eA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618475116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bQmWZhJFBGurEcgsfC0EuOHiXGG/UZMr42BKHCg0CM=; b=UJbcKBLM63tXFdhL6+sbafxYYoa0aUY/icViLfFSJ3OpAIqwZ3EUxYDHXeuiawYzlbpV1q zkNBIpUjZlT9iEScEp5M68IQSwUKFdPl6Lks6dbTmfD8MpuLrNpc0N5IzAyhrGr+Mt0/WN ep1A56TsRhtbds8aPFUdyGazSylvnuE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-TN07U8r-Od-6qmW_jA9Dqw-1; Thu, 15 Apr 2021 04:25:14 -0400 X-MC-Unique: TN07U8r-Od-6qmW_jA9Dqw-1 Received: by mail-ej1-f70.google.com with SMTP id p26-20020a170906a01ab0290373d37378f3so657406ejy.3 for ; Thu, 15 Apr 2021 01:25:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/bQmWZhJFBGurEcgsfC0EuOHiXGG/UZMr42BKHCg0CM=; b=QkxyeDCE0tZ7pxmZRL++SUDZu9WwzDj54xR3DTVMzIaSt4nQdl383O0xQ8dO87AxzK ThPaBLe6HzKRIbJJcCdvIYfTrlVWjMl2SBORvotu+5IS8NWNOg2lAmVpHIczHCeOQ/fV fw0byMdwkzZEw/hM9JrkMOfYKTq/+7DA6+KK+ndHq0fPU+SZTKUulaq7vEVzNTr2dgmf jx7g5f/dvVwYFNLnYTMTeqY5e2dak6R7KIEYwm9ziOxRwfIjgnPJyB2P3lX+JmwheZQr 9joDnY06SCRhUiE76CVJ6i6VjlR3SlX1AzB4Zq3sCYGStQ47ImnNyzi2Q22UqhzIcHES 8Q8g== X-Gm-Message-State: AOAM531/7zvqYUurb7Q1VR1BtlzVozT3wWJ0Sy71e/impDczM/91zhSQ l2EiqKTjTU1gDL/32C4oQGUw9orYmX0jnhRKP8Sv1LDn4hRxqKaUlfA4K8Dm24oOBRx+nl0j8IC jIY6zykH1Li2ds6LZ/pUAqyG+Nw== X-Received: by 2002:a17:906:fb90:: with SMTP id lr16mr2188966ejb.173.1618475113127; Thu, 15 Apr 2021 01:25:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV9d4Hf8P/msHacfoZkJ3KBX3z8yqEirLBflCXrob29FKDQvETDro/hTdN8fxJUXyuYv/GnQ== X-Received: by 2002:a17:906:fb90:: with SMTP id lr16mr2188956ejb.173.1618475112977; Thu, 15 Apr 2021 01:25:12 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id bm13sm1380535ejb.75.2021.04.15.01.25.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 01:25:12 -0700 (PDT) Subject: Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include To: Masahiro Yamada References: <20210415072700.147125-1-masahiroy@kernel.org> <20210415072700.147125-2-masahiroy@kernel.org> <9d33ee98-9de3-2215-0c0b-cc856cec1b69@redhat.com> From: Paolo Bonzini Message-ID: <2e46231f-1d30-6a6f-c768-f34295376d0a@redhat.com> Date: Thu, 15 Apr 2021 10:25:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , kvm@vger.kernel.org, Alexei Starovoitov , Paul Mackerras , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Janosch Frank , Daniel Borkmann , clang-built-linux , John Fastabend , Andrii Nakryiko , Christian Borntraeger , Harish , Yonghong Song , Linux Kbuild mailing list , KP Singh , Nathan Chancellor , Networking , Nick Desaulniers , Linux Kernel Mailing List , bpf , linuxppc-dev , Martin KaFai Lau Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 15/04/21 10:04, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:40 PM Paolo Bonzini wrote: >> I think it would make sense to add try-run, cc-option and >> .DELETE_ON_ERROR to tools/build/Build.include? > > To be safe, I just copy-pasted what the makefiles need. > If someone wants to refactor the tool build system, that is fine, > but, to me, I do not see consistent rules or policy under tools/. "Please put this in a common file instead of introducing duplication" is not asking for wholesale refactoring. Paolo