From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jason Wang <wangborong@cdjrlc.com>, leoyang.li@nxp.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, qiang.zhao@nxp.com
Subject: Re: [PATCH] soc: fsl: qe: Fix typo in a comment
Date: Mon, 15 Nov 2021 09:06:05 +0100 [thread overview]
Message-ID: <2ebdfb0c-867e-37f0-2c77-41c83b4048d0@csgroup.eu> (raw)
In-Reply-To: <20211113055900.212568-1-wangborong@cdjrlc.com>
Le 13/11/2021 à 06:59, Jason Wang a écrit :
> The double `is' in a comment is repeated, thus one of them
> should be removed.
You are also clean blanks it seems, so say it or don't do it.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/soc/fsl/qe/qe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
> index 4d38c80f8be8..b3c226eb5292 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -147,7 +147,7 @@ EXPORT_SYMBOL(qe_issue_cmd);
> * memory mapped space.
> * The BRG clock is the QE clock divided by 2.
> * It was set up long ago during the initial boot phase and is
> - * is given to us.
> + * given to us.
> * Baud rate clocks are zero-based in the driver code (as that maps
> * to port numbers). Documentation uses 1-based numbering.
> */
> @@ -421,7 +421,7 @@ static void qe_upload_microcode(const void *base,
>
> for (i = 0; i < be32_to_cpu(ucode->count); i++)
> iowrite32be(be32_to_cpu(code[i]), &qe_immr->iram.idata);
> -
> +
This change is not linked to the double "is".
> /* Set I-RAM Ready Register */
> iowrite32be(QE_IRAM_READY, &qe_immr->iram.iready);
> }
>
next prev parent reply other threads:[~2021-11-15 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 5:59 [PATCH] soc: fsl: qe: Fix typo in a comment Jason Wang
2021-11-15 8:06 ` Christophe Leroy [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-11 9:08 [PATCH] soc: fsl: qe: fix " Jason Wang
2022-01-07 2:25 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ebdfb0c-867e-37f0-2c77-41c83b4048d0@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).