From: Sathvika Vasireddy <sv@linux.ibm.com>
To: Kautuk Consul <kconsul@linux.vnet.ibm.com>
Cc: Fabiano Rosas <farosas@linux.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
linux-kernel@vger.kernel.org,
Sathvika Vasireddy <sv@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] arch/powerpc/kvm: kvmppc_hv_entry: remove .global scope
Date: Mon, 20 Feb 2023 12:35:09 +0530 [thread overview]
Message-ID: <2fa8dd2a-1650-4adc-de2b-0f14dca683ed@linux.ibm.com> (raw)
In-Reply-To: <20230220052355.109033-2-kconsul@linux.vnet.ibm.com>
Hi Kautuk,
On 20/02/23 10:53, Kautuk Consul wrote:
> kvmppc_hv_entry isn't called from anywhere other than
> book3s_hv_rmhandlers.S itself. Removing .global scope for
> this function.
>
> Signed-off-by: Kautuk Consul <kconsul@linux.vnet.ibm.com>
> ---
> arch/powerpc/kvm/book3s_hv_rmhandlers.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> index acf80915f406..7e063fde7adc 100644
> --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> @@ -502,7 +502,6 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S)
> * *
> *****************************************************************************/
>
> -.global kvmppc_hv_entry
> kvmppc_hv_entry:
>
> /* Required state:
I see the following objtool warning with this patch applied.
arch/powerpc/kvm/book3s_hv_rmhandlers.o: warning: objtool: .text+0x48:
unannotated intra-function call
Annotating kvmppc_hv_entry symbol with SYM_FUNC_START_LOCAL and
SYM_FUNC_END macros should help fix this warning.
Thanks,
Sathvika
next prev parent reply other threads:[~2023-02-20 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 5:23 [PATCH 0/2] Improving calls to kvmppc_hv_entry Kautuk Consul
2023-02-20 5:23 ` [PATCH 1/2] arch/powerpc/kvm: kvmppc_hv_entry: remove .global scope Kautuk Consul
2023-02-20 7:05 ` Sathvika Vasireddy [this message]
2023-02-20 7:28 ` Kautuk Consul
2023-02-20 8:01 ` Sathvika Vasireddy
2023-02-20 8:11 ` Kautuk Consul
2023-02-20 9:17 ` Kautuk Consul
2023-02-23 5:09 ` Kautuk Consul
2023-02-24 11:15 ` Sathvika Vasireddy
2023-03-06 12:22 ` Kautuk Consul
2023-02-20 5:23 ` [PATCH 2/2] arch/powerpc/kvm: kvmppc_hv_entry: remove r4 argument Kautuk Consul
2023-03-06 12:24 ` Kautuk Consul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa8dd2a-1650-4adc-de2b-0f14dca683ed@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=farosas@linux.ibm.com \
--cc=kconsul@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).