From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Document and implement an improved flash device binding for powerpc (v5)
Date: Fri, 7 Sep 2007 16:25:10 +0200 [thread overview]
Message-ID: <2fcd14e175d5a215cd8d602ac74fce21@kernel.crashing.org> (raw)
In-Reply-To: <20070907032353.GA3082@localhost.localdomain>
> This patch replaces the binding for flash chips in
> booting-without-of.txt with an clarified and improved version. It
> also makes drivers/mtd/maps/physmap_of.c recognize this new binding.
> Finally it revises the Ebony device tree source to use the new binding
> as an example.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Segher Boessenkool <segher@kernel.crashing.org>
Thanks for doing this work David!
> + /* First look for RedBoot table or partitions on the command
> + * line, these take precedence over device tree information */
Any specific reason you chose this order? Just curious...
> + .data = (void *)"jedec_probe",
Hrm, this cast is only getting rid of the const-ness of the
string literal -- maybe .data should be declared const, or
does the majority of users want it writable?
Segher
next prev parent reply other threads:[~2007-09-07 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 3:23 Document and implement an improved flash device binding for powerpc (v5) David Gibson
2007-09-07 14:25 ` Segher Boessenkool [this message]
2007-09-07 14:28 ` Josh Boyer
2007-09-10 3:00 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fcd14e175d5a215cd8d602ac74fce21@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).