From: Leonardo Bras <leobras.c@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Ram Pai <linuxram@us.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] powerpc/pseries/iommu: Make use of DDW even if it does not map the partition
Date: Wed, 01 Jul 2020 21:54:41 -0300 [thread overview]
Message-ID: <3049147914a4a04a095a3f3bd74a7c7ad4d961ad.camel@gmail.com> (raw)
In-Reply-To: <2c5dc8d2-f379-5a5f-844a-f4eea233f265@ozlabs.ru>
On Thu, 2020-07-02 at 10:31 +1000, Alexey Kardashevskiy wrote:
> > In fact, there is a lot of places in this file where it's called direct
> > window. Should I replace everything?
> > Should it be in a separated patch?
>
> If it looks simple and you write a nice commit log explaining all that
> and why you are not reusing the existing ibm,dma-window property
> for that - sure, do it :)
Nice, I will do that :)
> (to provide a clue what "reset" will reset to? is there any other
> reason?)
That's the main reason here.
The way I perceive this, ibm,dma-window should only point to the
default DMA window, which is guaranteed to always be the same, even if
it's destroyed and re-created. So there I see no point destroying /
overwriting it.
On the other hand, I also thought about using a new node name for this
window, but it would be very troublesome and I could see no real gain.
Thanks !
next prev parent reply other threads:[~2020-07-02 0:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 6:24 [PATCH v2 0/6] Remove default DMA window before creating DDW Leonardo Bras
2020-06-24 6:24 ` [PATCH v2 1/6] powerpc/pseries/iommu: Create defines for operations in ibm, ddw-applicable Leonardo Bras
2020-07-01 8:16 ` [PATCH v2 1/6] powerpc/pseries/iommu: Create defines for operations in ibm,ddw-applicable Alexey Kardashevskiy
2020-07-01 13:28 ` Leonardo Bras
2020-07-02 0:21 ` Alexey Kardashevskiy
2020-07-02 0:36 ` Leonardo Bras
2020-07-02 0:43 ` Alexey Kardashevskiy
2020-07-02 0:46 ` Leonardo Bras
2020-06-24 6:24 ` [PATCH v2 2/6] powerpc/pseries/iommu: Update call to ibm, query-pe-dma-windows Leonardo Bras
2020-07-01 8:17 ` [PATCH v2 2/6] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows Alexey Kardashevskiy
2020-07-01 14:04 ` Leonardo Bras
2020-07-02 0:18 ` Alexey Kardashevskiy
2020-07-02 0:28 ` Leonardo Bras
2020-06-24 6:24 ` [PATCH v2 3/6] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window Leonardo Bras
2020-06-24 6:24 ` [PATCH v2 4/6] powerpc/pseries/iommu: Remove default DMA window before creating DDW Leonardo Bras
2020-07-01 8:17 ` Alexey Kardashevskiy
2020-07-01 19:48 ` Leonardo Bras
2020-07-02 0:25 ` Alexey Kardashevskiy
2020-06-24 6:24 ` [PATCH v2 5/6] powerpc/pseries/iommu: Make use of DDW even if it does not map the partition Leonardo Bras
2020-06-26 15:23 ` Leonardo Bras
2020-06-26 17:55 ` Leonardo Bras
2020-07-01 8:16 ` Alexey Kardashevskiy
2020-07-01 19:57 ` Leonardo Bras
2020-07-01 23:48 ` Leonardo Bras
2020-07-02 0:31 ` Alexey Kardashevskiy
2020-07-02 0:54 ` Leonardo Bras [this message]
2020-07-03 6:27 ` Leonardo Bras
2020-06-24 6:24 ` [PATCH v2 6/6] powerpc/pseries/iommu: Avoid errors when DDW starts at 0x00 Leonardo Bras
2020-06-26 17:46 ` Leonardo Bras
2020-07-01 8:04 ` Alexey Kardashevskiy
2020-07-01 19:59 ` Leonardo Bras
2020-06-24 15:54 ` [PATCH v2 0/6] Remove default DMA window before creating DDW Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3049147914a4a04a095a3f3bd74a7c7ad4d961ad.camel@gmail.com \
--to=leobras.c@gmail.com \
--cc=aik@ozlabs.ru \
--cc=bauerman@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).