From: Jarkko Sakkinen <jarkko@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Paul Mackerras <paulus@samba.org>,
Peter Huewe <peterhuewe@gmx.de>,
linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: ibmvtpm: Make use of dma_alloc_coherent()
Date: Tue, 12 Oct 2021 18:29:58 +0300 [thread overview]
Message-ID: <31619f2f192a4f1584e458f468422cf6e8f7542f.camel@kernel.org> (raw)
In-Reply-To: <20211010160147.590-1-caihuoqing@baidu.com>
On Mon, 2021-10-11 at 00:01 +0800, Cai Huoqing wrote:
> Replacing kmalloc/kfree/get_zeroed_page/free_page/dma_map_single/
~~~~~~~~~
Replace
> dma_unmap_single() with dma_alloc_coherent/dma_free_coherent()
> helps to reduce code size, and simplify the code, and coherent
> DMA will not clear the cache every time.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
If this does not do functionally anything useful, there's no
reason to apply this.
It is also missing information why the substitution is possible.
Field tested code is better than clean code, i.e. we don not
risk at having possible new regressions just for a bit nicer
layout...
/Jarkko
next prev parent reply other threads:[~2021-10-12 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 16:01 [PATCH] tpm: ibmvtpm: Make use of dma_alloc_coherent() Cai Huoqing
2021-10-12 15:29 ` Jarkko Sakkinen [this message]
2021-10-12 15:43 ` Jason Gunthorpe
2021-10-12 17:40 ` Jarkko Sakkinen
2021-10-12 21:01 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31619f2f192a4f1584e458f468422cf6e8f7542f.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).