From: David Howells <dhowells@redhat.com>
To: Kevin Diggs <kevdig@hypersurf.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: checkpatch nits ...
Date: Sun, 24 Aug 2008 13:23:05 +0100 [thread overview]
Message-ID: <31720.1219580585@redhat.com> (raw)
In-Reply-To: <48AF5818.7010802@hypersurf.com>
Kevin Diggs <kevdig@hypersurf.com> wrote:
> The entire block is:
>
> __asm__ __volatile__ (
> "addi %0,%3,-1\n"
> "andc %1,%3,%0\n"
> "cntlzw %1,%1\n"
> "subfic %1,%1,31\n"
> "cntlzw %0,%2\n":
> "=r"(cntlz), "=r"(cnttz):
> "r"(tmp), "b"(cnttz)
> );
As long as this has no side effects, the __volatile__ isn't necessary. If the
only effect is to produce the specified outputs based on the specified inputs,
the code can be moved or eliminated if the outputs aren't used.
David
prev parent reply other threads:[~2008-08-24 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 0:21 checkpatch nits Kevin Diggs
2008-08-23 0:40 ` Sean MacLennan
2008-08-23 8:57 ` Arnd Bergmann
2008-08-27 7:49 ` Wolfram Sang
2008-08-28 7:51 ` Andy Whitcroft
2008-08-24 12:23 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31720.1219580585@redhat.com \
--to=dhowells@redhat.com \
--cc=kevdig@hypersurf.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).