From: "Sébastien Chrétien" <sebastien.chretien.enseirb@gmail.com>
To: benh@kernel.crashing.org
Cc: Linuxppc-dev@ozlabs.org
Subject: Re: [MPC7448] machdep_calls
Date: Tue, 19 Aug 2008 11:23:05 +0200 [thread overview]
Message-ID: <319b0ac50808190223y7f378b46o3e485335e619e0cc@mail.gmail.com> (raw)
In-Reply-To: <1219130863.8062.39.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 3243 bytes --]
So I will write .setup_arch of machine_call structure.
When is ppc_md.setup_arch() called ?
2008/8/19, Benjamin Herrenschmidt <benh@kernel.crashing.org>:
>
> On Tue, 2008-08-19 at 09:00 +0200, Sébastien Chrétien wrote:
> > I have no screen that's why I have to use UART. I followed the CPM
> > model in head_32.S :
> > #ifdef CONFIG_PPC_EARLY_DEBUG_CPM
> > setup_cpm_bat:
> > lis r8, 0xf000
> > ori r8, r8, 0x002a
> > mtspr SPRN_DBAT1L, r8
> >
> > lis r11, 0xf000
> > ori r11, r11, (BL_1M << 2) | 2
> > mtspr SPRN_DBAT1U, r11
> >
> > blr
> > #endif
>
>
> The "EARLY DEBUG" stuff is a pile of hacks to help with bringup,
> it's definitely not a long term solution to your problems.
>
> You may also want to look at Grant Likely's work on doing proper
> early ioremap using BATs.
>
>
> > With this code I can use udbg.
> >
> > According to you, what is the best way ?
>
>
> The above is fine for early debug console. But that's definitely
> not the only kind of thing you may want to put in your setup_arch()...
> Look at what others do.
>
> Ben.
>
>
> > 2008/8/18, Benjamin Herrenschmidt <benh@kernel.crashing.org>:
> > On Mon, 2008-08-18 at 16:17 +0200, Sébastien Chrétien wrote:
> > > The mpc7448hpc2 uses a tsi108-bridge. My board uses an IP on
> > a FPGA..
> > > I read the code of mpc7448_hpc2.c.
> > > It uses a ioremap in order to iniatilize the tsi108
> > registers. But I
> > > have already initialized MMU with my registers in HEAD_32.S.
> > Do I need
> > > to use ioremap in setup_arch() ?
> >
> >
> > Why did you hack head_32.S ? You shouldn't do that... This is
> > common
> > code, not platform code.
> >
> > Ben.
> >
> > >
> > >
> > >
> > > 2008/8/18, Michael Ellerman <michael@ellerman.id.au>:
> > > On Mon, 2008-08-18 at 13:35 +0200, Sébastien
> > Chrétien wrote:
> > > > Can somebody explain me the aim of the
> > > function "setup_arch" in the
> > > > machine_call structure ?
> > >
> > >
> > > Is this MPC7448 anything like an mpc7448hpc2 ?
> > >
> > > If so maybe you should start by looking at the code
> > for it in:
> > >
> > > arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c
> > >
> > > Even if it's not related, that will give you some
> > idea of what
> > > the
> > > callbacks are for.
> > >
> > > cheers
> > >
> > > --
> > > Michael Ellerman
> > > OzLabs, IBM Australia Development Lab
> > >
> > > wwweb: http://michael.ellerman.id.au
> > > phone: +61 2 6212 1183 (tie line 70 21183)
> > >
> > > We do not inherit the earth from our ancestors,
> > > we borrow it from our children. - S.M.A.R.T Person
> > >
> > >
> >
> >
>
>
[-- Attachment #2: Type: text/html, Size: 7166 bytes --]
next prev parent reply other threads:[~2008-08-19 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 8:45 [MPC7448] machdep_calls Sébastien Chrétien
2008-08-18 9:27 ` Benjamin Herrenschmidt
2008-08-18 11:22 ` Sébastien Chrétien
2008-08-18 11:35 ` Sébastien Chrétien
2008-08-18 12:20 ` Michael Ellerman
2008-08-18 14:17 ` Sébastien Chrétien
2008-08-18 21:39 ` Benjamin Herrenschmidt
2008-08-19 7:00 ` Sébastien Chrétien
2008-08-19 7:27 ` Benjamin Herrenschmidt
2008-08-19 9:23 ` Sébastien Chrétien [this message]
2008-08-18 21:11 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=319b0ac50808190223y7f378b46o3e485335e619e0cc@mail.gmail.com \
--to=sebastien.chretien.enseirb@gmail.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=benh@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).