From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C1DEF2C00F7 for ; Fri, 26 Apr 2013 03:33:01 +1000 (EST) In-Reply-To: <1366909096.30341.3@snotra> References: <1366684776-10946-1-git-send-email-hongtao.jia@freescale.com> <1366684776-10946-2-git-send-email-hongtao.jia@freescale.com> <1366909096.30341.3@snotra> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <31FA2909-1F69-4400-9908-7F6D34D9391A@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH 2/2 V7] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx Date: Thu, 25 Apr 2013 19:32:30 +0200 To: Scott Wood Cc: linuxppc-dev@lists.ozlabs.org, Jia Hongtao , B07421@freescale.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> * Remove A variant of load instruction emulation >> Why is this? You handle all other simple load insns, there is >> nothing special about LHA. (I reviewed the V4 email thread, no >> reason for the chance is given there). > > The LHA implementation in V5 was incorrect (didn't sign-extend). The history on the current version says that it was _removed_ in V5 :-) So an off-by-one in the history, I suppose. It would be totally trivial to implement it correctly, seems a bit silly to remove it? Segher