From: Christophe Leroy <christophe.leroy@c-s.fr>
To: WANG Wenhu <wenhu.wang@vivo.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Richard Fontana <rfontana@redhat.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: kernel@vivo.com, trivial@kernel.org
Subject: Re: [PATCH v2] powerpc/fsl-85xx: fix compile error
Date: Fri, 13 Mar 2020 18:45:11 +0100 [thread overview]
Message-ID: <320843ad-32d5-8799-7c4a-150fa5fd7ef8@c-s.fr> (raw)
In-Reply-To: <20200313171953.63205-1-wenhu.wang@vivo.com>
Le 13/03/2020 à 18:19, WANG Wenhu a écrit :
> Include "linux/of_address.h" to fix the compile error for
> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.
>
> CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’:
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration]
> l2ctlr = of_iomap(dev->dev.of_node, 0);
> ^~~~~~~~
> pci_iomap
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> l2ctlr = of_iomap(dev->dev.of_node, 0);
> ^
> cc1: all warnings being treated as errors
> scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
>
> Fixes: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
Shouldn't you Cc stable as well ?
> Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
> ---
What's the difference between v1 and v2 ?
Christophe
next prev parent reply other threads:[~2020-03-13 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 17:19 [PATCH v2] powerpc/fsl-85xx: fix compile error WANG Wenhu
2020-03-13 17:45 ` Christophe Leroy [this message]
2020-03-13 18:17 ` 王文虎
2020-03-13 19:24 ` Christophe Leroy
2020-03-14 4:50 ` 王文虎
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320843ad-32d5-8799-7c4a-150fa5fd7ef8@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=allison@lohutok.net \
--cc=benh@kernel.crashing.org \
--cc=kernel@vivo.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=wenhu.wang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).