From: Milton Miller <miltonm@bga.com>
To: Arnd Bergmann <abergman@de.ibm.com>
Cc: Arnd Bergmann <arnd.bergmann@de.ibm.com>,
stk@de.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
hpenner@de.ibm.com, cbe-oss-dev@ozlabs.org
Subject: Re: [patch 06/13] powerpc: cell interrupt controller updates
Date: Fri, 24 Mar 2006 11:43:39 -0600 [thread overview]
Message-ID: <32140afe2349e8f1726d188eb85c780c@bga.com> (raw)
In-Reply-To: <20060323203521.862355000@dyn-9-152-242-103.boeblingen.de.ibm.com>
On Mar 22, 2006, at 5:00 PM, Arnd Bergmann wrote:
> static void spider_enable_irq(unsigned int irq)
> {
> + int nodeid = (irq / IIC_NODE_STRIDE) * 0x10;
> void __iomem *cfg = spider_get_irq_config(irq);
> irq = spider_get_nr(irq);
>
> - out_be32(cfg, in_be32(cfg) | 0x3107000eu);
> + out_be32(cfg, in_be32(cfg) | 0x3107000eu | nodeid);
> out_be32(cfg + 4, in_be32(cfg + 4) | 0x00020000u | irq);
> }
>
I just did a quick read of the code, but my first thought is what if
some other node id was previously set? Perhaps you should mask off
some bits before or'ing in the node id?
milton
next prev parent reply other threads:[~2006-03-24 17:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 20:34 [patch 00/13] Cell kernel updates Arnd Bergmann
2006-03-22 23:00 ` [patch 01/13] powerpc: hvc_console updates Arnd Bergmann
2006-03-27 4:00 ` Paul Mackerras
2006-03-27 19:25 ` [updated patch 1/2] " Arnd Bergmann
2006-03-28 5:23 ` Paul Mackerras
2006-03-27 19:26 ` [updated patch 2/2] powerpc: add hvc backend for rtas Arnd Bergmann
2006-03-22 23:00 ` [patch 02/13] " Arnd Bergmann
2006-03-23 21:32 ` Olof Johansson
2006-03-23 22:36 ` [Cbe-oss-dev] " Arnd Bergmann
2006-03-23 22:49 ` Olof Johansson
2006-03-24 18:58 ` powerpc: fix hvc-rtas comments Arnd Bergmann
2006-03-22 23:00 ` [patch 03/13] powerpc: update cell platform detection Arnd Bergmann
2006-03-22 23:00 ` [patch 04/13] powerpc: fix cell iommu setup Arnd Bergmann
2006-03-22 23:00 ` [patch 05/13] powerpc: update cell defconfig Arnd Bergmann
2006-03-22 23:00 ` [patch 06/13] powerpc: cell interrupt controller updates Arnd Bergmann
2006-03-23 22:15 ` Benjamin Herrenschmidt
2006-03-24 18:47 ` [PATCH] powerpc: use guarded ioremap for on-chip mappings Arnd Bergmann
2006-03-24 17:43 ` Milton Miller [this message]
2006-03-24 18:05 ` [patch 06/13] powerpc: cell interrupt controller updates Arnd Bergmann
2006-03-24 18:46 ` [PATCH] powerpc: fix spider-pic affinity setting Arnd Bergmann
2006-03-22 23:00 ` [patch 07/13] powerpc: work around a cell interrupt HW bug Arnd Bergmann
2006-03-22 23:00 ` [patch 08/13] powerpc: declare arch syscalls in <asm/syscalls.h> Arnd Bergmann
2006-03-22 23:00 ` [patch 09/13] spufs: allow SPU code to do syscalls Arnd Bergmann
2006-03-22 23:00 ` [patch 10/13] add sys_unshare to syscalls.h Arnd Bergmann
2006-03-22 23:00 ` [patch 11/13] spufs: implement mfc access for PPE-side DMA Arnd Bergmann
2006-03-22 23:00 ` [patch 12/13] spufs: enable SPE problem state MMIO access Arnd Bergmann
2006-03-22 23:00 ` [patch 13/13] spufs: initialize context correctly Arnd Bergmann
2006-03-24 18:49 ` [PATCH] spufs: Fix endless protection fault on LS writes by SPE Arnd Bergmann
2006-03-27 19:27 ` [PATCH] fix __init/__exit annotations for spufs Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32140afe2349e8f1726d188eb85c780c@bga.com \
--to=miltonm@bga.com \
--cc=abergman@de.ibm.com \
--cc=arnd.bergmann@de.ibm.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=hpenner@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=stk@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).