From: Tirumala Marri <tmarri@apm.com>
To: Ilya Yanok <yanok@emcraft.com>, linuxppc-dev@ozlabs.org
Subject: RE: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
Date: Tue, 21 Sep 2010 09:51:32 -0700 [thread overview]
Message-ID: <322ffe990b9c7295977accbdec0e6e99@mail.gmail.com> (raw)
In-Reply-To: <loom.20100919T215645-646@post.gmane.org>
> -----Original Message-----
> From: linuxppc-dev-bounces+tmarri=amcc.com@lists.ozlabs.org
> [mailto:linuxppc-dev-bounces+tmarri=amcc.com@lists.ozlabs.org] On
> Behalf Of Ilya Yanok
> Sent: Sunday, September 19, 2010 1:01 PM
> To: linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
>
> Hi Tirumala,
>
> > drivers/dma/ppc4xx/adma.c | 4370 +++-------------------------
> ----------
> > drivers/dma/ppc4xx/adma.h | 116 +-
> > drivers/dma/ppc4xx/ppc4xx-adma.h | 4020
> +++++++++++++++++++++++++++++++++++
>
> You've moved tons of code to the header file. Why?
>
> Regards, Ilya.
>
My intention is to keep the SoC specific code in the header files.
Something iop-dma is also doing.
next prev parent reply other threads:[~2010-09-21 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 1:42 [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c tmarri
2010-09-18 21:09 ` Wolfgang Denk
2010-09-20 18:00 ` Tirumala Marri
2010-09-20 21:31 ` Wolfgang Denk
2010-09-19 20:00 ` Ilya Yanok
2010-09-21 16:51 ` Tirumala Marri [this message]
2010-09-23 20:22 ` Dan Williams
2010-09-23 22:39 ` Tirumala Marri
2010-09-24 6:58 ` Stefan Roese
2010-09-24 18:52 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=322ffe990b9c7295977accbdec0e6e99@mail.gmail.com \
--to=tmarri@apm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).