From: Arnd Bergmann <arnd@arndb.de>
To: "Andrew F. Davis" <afd@ti.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
Richard Purdie <rpurdie@rpsys.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
linux-pwm@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set
Date: Fri, 06 Jan 2017 00:12:13 +0100 [thread overview]
Message-ID: <32595176.b3HvexHCfd@wuerfel> (raw)
In-Reply-To: <f29ea3de-efb1-a406-db3e-b048e677f3a8@ti.com>
On Thursday, January 5, 2017 4:35:33 PM CET Andrew F. Davis wrote:
> On 01/05/2017 03:42 PM, Arnd Bergmann wrote:
> > On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
> >> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/
> >> obj-$(CONFIG_GAMEPORT) += input/gameport/
> >> obj-$(CONFIG_INPUT) += input/
> >> obj-$(CONFIG_RTC_LIB) += rtc/
> >> -obj-y += i2c/ media/
> >> +obj-y += i2c/
> >> +obj-$(CONFIG_MEDIA_SUPPORT) += media/
> >> obj-$(CONFIG_PPS) += pps/
> >> obj-y += ptp/
> >> obj-$(CONFIG_W1) += w1/
> >>
> >
> > This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers
> > inside of drivers/media/ are built-in, we will fail to enter the directory,
> > see drivers/media/Makefile.
>
> Not sure if I see this, it looks like everything in drivers/media/
> depends on CONFIG_MEDIA_SUPPORT (directly or indirectly). If
> CONFIG_MEDIA_SUPPORT is =m then all dependents should be locked out of
> being built-in.
>
> Any bool symbol that controls compilation of source that depends on a
> tristate symbol is broken and should be fixed anyway.
I don't think it's this easy, we have a couple of cases where that doesn't
work. I have not looked at the media example in detail, but at least it
looks intentional.
Note that drivers/media is rather creative with expressing dependencies.
Arnd
prev parent reply other threads:[~2017-01-05 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 21:01 [PATCH v2 0/6] Remove unneeded build directory traversals Andrew F. Davis
2017-01-05 21:01 ` [PATCH v2 1/6] pwm: Only descend into pwm directory when CONFIG_PWM is set Andrew F. Davis
2017-01-05 21:01 ` [PATCH v2 2/6] amba: Only descend into amba directory when CONFIG_ARM_AMBA " Andrew F. Davis
2017-01-05 21:01 ` [PATCH v2 3/6] NFC: Only descend into nfc directory when CONFIG_NFC " Andrew F. Davis
2017-01-05 21:01 ` [PATCH v2 4/6] macintosh: Only descend into directory when CONFIG_MACINTOSH_DRIVERS " Andrew F. Davis
2017-01-05 21:01 ` [PATCH v2 5/6] auxdisplay: Only descend into directory when CONFIG_AUXDISPLAY " Andrew F. Davis
2017-01-05 21:01 ` [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT " Andrew F. Davis
2017-01-05 21:42 ` Arnd Bergmann
2017-01-05 22:35 ` Andrew F. Davis
2017-01-05 23:12 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32595176.b3HvexHCfd@wuerfel \
--to=arnd@arndb.de \
--cc=afd@ti.com \
--cc=aloisio.almeida@openbossa.org \
--cc=benh@kernel.crashing.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@osg.samsung.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).