From: Kumar Gala <galak@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC][PATCH] powerpc/book3e: Fix CPU feature handling on e5500
Date: Wed, 6 Apr 2011 07:26:00 -0500 [thread overview]
Message-ID: <32DBACBF-FCBE-4FBD-BD87-0CA3CD670C10@kernel.crashing.org> (raw)
In-Reply-To: <20110406154147.f736d92e.sfr@canb.auug.org.au>
On Apr 6, 2011, at 12:41 AM, Stephen Rothwell wrote:
> Hi Kumar,
>=20
> On Wed, 6 Apr 2011 00:29:32 -0500 Kumar Gala =
<galak@kernel.crashing.org> wrote:
>>=20
>> * I'm concerned if its ok to assume 'enum' can handle a 64-bit mask =
or not.
>> I'm assuming this is the reason that we use a #define on =
__powerpc64__
>=20
> enums are *ints* and therefore 32 bit. gcc can cope, but warns about =
it
> (I think). So we must use the #define if any of the included bits are
> above 2^32.
Thanks, I'll rework the patch to use #define.
- k=
prev parent reply other threads:[~2011-04-06 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 5:29 [RFC][PATCH] powerpc/book3e: Fix CPU feature handling on e5500 Kumar Gala
2011-04-06 5:41 ` Stephen Rothwell
2011-04-06 12:26 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32DBACBF-FCBE-4FBD-BD87-0CA3CD670C10@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox