From: Alexander Graf <agraf@suse.de>
To: Thomas Huth <thuth@redhat.com>
Cc: "benh@au1.ibm.com" <benh@au1.ibm.com>,
Paul Mackerras <paulus@ozlabs.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
Alexander Graf <agraf@suse.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register
Date: Wed, 2 Sep 2015 10:26:16 +0200 [thread overview]
Message-ID: <334DA903-4793-45C4-9FCB-D9B022DE74A2@suse.de> (raw)
In-Reply-To: <55E6A48D.5070800@redhat.com>
> Am 02.09.2015 um 09:26 schrieb Thomas Huth <thuth@redhat.com>:
>
>> On 02/09/15 00:55, Benjamin Herrenschmidt wrote:
>>> On Wed, 2015-09-02 at 08:45 +1000, Paul Mackerras wrote:
>>> On Wed, Sep 02, 2015 at 08:25:05AM +1000, Benjamin Herrenschmidt
>>> wrote:
>>>> On Tue, 2015-09-01 at 23:41 +0200, Thomas Huth wrote:
>>>>> The size of the Problem State Priority Boost Register is only
>>>>> 32 bits, so let's change the type of the corresponding variable
>>>>> accordingly to avoid future trouble.
>>>>
>>>> It's not future trouble, it's broken today for LE and this should
>>>> fix
>>>> it BUT ....
>>>
>>> No, it's broken today for BE hosts, which will always see 0 for the
>>> PSPB register value. LE hosts are fine.
>
> Right ... I just meant that nobody really experienced trouble with this
> today yet, but the bug is already present now already of course.
Sounds like a great candidate for kvm-unit-tests then, no? ;)
Alex
next prev parent reply other threads:[~2015-09-02 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 21:41 [PATCH] KVM: ppc: Fix size of the PSPB register Thomas Huth
2015-09-01 22:24 ` Paul Mackerras
2015-09-01 22:30 ` Benjamin Herrenschmidt
2015-09-02 7:16 ` Thomas Huth
2015-09-01 22:25 ` Benjamin Herrenschmidt
2015-09-01 22:45 ` Paul Mackerras
2015-09-01 22:55 ` Benjamin Herrenschmidt
2015-09-02 7:26 ` Thomas Huth
2015-09-02 8:26 ` Alexander Graf [this message]
2015-09-02 8:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=334DA903-4793-45C4-9FCB-D9B022DE74A2@suse.de \
--to=agraf@suse.de \
--cc=agraf@suse.com \
--cc=benh@au1.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox