From: Segher Boessenkool <segher@kernel.crashing.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: fix i2c device string format
Date: Thu, 9 Aug 2007 21:45:46 +0200 [thread overview]
Message-ID: <3368b27f860fafb35d10f6352e9055bf@kernel.crashing.org> (raw)
In-Reply-To: <Pine.LNX.4.60.0708080023030.8493@poirot.grange>
>> strncpy() won't put a terminating zero on there, is everything
>> that uses the resulting string okay with that? Also, if the
>> name gets cut short, it might match some _other_ expected name.
>
> On Wed, 1 Aug 2007, Scott Wood wrote:
>
>> You could use strlcpy() instead, which always leaves a zero
>> terminator.
>
> The patch below does exactly this - uses strlcpy() to guarantee
> strings in
> i2c device type and driver_name fields are 0-terminated.
You're not checking the return values of these calls. This would
be a good function to put attribute warn_unused_result on :-)
Segher
next prev parent reply other threads:[~2007-08-09 19:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 19:20 [PATCH] powerpc: Add of_register_i2c_devices() Guennadi Liakhovetski
2007-07-01 23:36 ` Kumar Gala
2007-07-02 11:56 ` Segher Boessenkool
2007-07-02 12:03 ` Segher Boessenkool
2007-07-02 20:11 ` Guennadi Liakhovetski
2007-07-02 22:46 ` Scott Wood
2007-07-02 23:10 ` Segher Boessenkool
2007-07-02 23:06 ` Segher Boessenkool
2007-07-03 22:34 ` Guennadi Liakhovetski
2007-07-03 23:02 ` Segher Boessenkool
2007-07-04 5:28 ` Guennadi Liakhovetski
2007-07-04 12:19 ` Segher Boessenkool
2007-07-04 17:50 ` Guennadi Liakhovetski
2007-07-17 22:17 ` Guennadi Liakhovetski
2007-07-19 15:32 ` Segher Boessenkool
2007-07-19 22:07 ` Guennadi Liakhovetski
2007-07-20 7:26 ` Segher Boessenkool
2007-07-20 20:26 ` Guennadi Liakhovetski
2007-07-31 22:55 ` Segher Boessenkool
2007-08-01 5:41 ` Guennadi Liakhovetski
2007-08-01 8:18 ` Segher Boessenkool
2007-08-01 20:36 ` Guennadi Liakhovetski
2007-08-01 20:42 ` Scott Wood
2007-08-07 22:32 ` [PATCH] powerpc: fix i2c device string format Guennadi Liakhovetski
2007-08-09 19:45 ` Segher Boessenkool [this message]
2007-08-09 20:46 ` Guennadi Liakhovetski
2007-08-10 17:44 ` Segher Boessenkool
2007-08-15 6:23 ` Paul Mackerras
2007-08-15 19:15 ` Guennadi Liakhovetski
2007-08-15 21:29 ` Scott Wood
2007-08-15 22:23 ` Guennadi Liakhovetski
2007-08-16 0:36 ` Stephen Rothwell
2007-07-03 0:42 ` [PATCH] powerpc: Add of_register_i2c_devices() Benjamin Herrenschmidt
2007-07-03 12:33 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3368b27f860fafb35d10f6352e9055bf@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=g.liakhovetski@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).