From: Christian Lamparter <chunkeey@gmail.com>
To: linuxppc-dev@ozlabs.org
Subject: Re: [1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings
Date: Fri, 04 Jan 2019 21:46:51 +0100 [thread overview]
Message-ID: <3480116.KzcvcCly6l@debian64> (raw)
In-Reply-To: <43V85g033hz9sCX@ozlabs.org>
On Wednesday, January 2, 2019 12:31:50 PM CET Michael Ellerman wrote:
> On Tue, 2019-01-01 at 03:56:00 UTC, Michael Ellerman wrote:
> > Currently the code produces several warnings, eg:
> >
> > arch/powerpc/platforms/4xx/ocm.c:240:38: error: format '%llx'
> > expects argument of type 'long long unsigned int', but argument 3
> > has type 'phys_addr_t {aka unsigned int}'
> > seq_printf(m, "PhysAddr : 0x%llx\n", ocm->phys);
> > ~~~^ ~~~~~~~~~
> >
> > Fix it by using the special %pa[p] format for printing phys_addr_t.
> > Note we need to pass the value by reference for the special specifier
> > to work.
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Series applied to powerpc fixes.
>
> https://git.kernel.org/powerpc/c/52b88fa1e8c7bae03bb691178a9f8b
Well, I guess I'm a late. I had issues with the getting 4.20+
crosscompiled on debian with make-kpkg.
Nevertheless, I finally got a working kernel and
on the MyBook Live APM82181:
---
root@mbl:/sys/kernel/debug# cat ppc4xx_ocm/info
PPC4XX OCM : 1
PhysAddr : 0x0000000400040000[p]
MemTotal : 32768 Bytes
MemTotal(NC) : 32768 Bytes
MemTotal(C) : 0 Bytes
NC.PhysAddr : 0x0000000400040000[p]
NC.VirtAddr : 0x6bc84b36
NC.MemTotal : 32768 Bytes
NC.MemFree : 32768 Bytes
C.PhysAddr : 0x0000000000000000[p]
C.VirtAddr : 0x (null)
C.MemTotal : 0 Bytes
C.MemFree : 0 Bytes
---
Yes, nobody is using the ocm. Though I do have a patch
for the crypto4xx and emac.
next prev parent reply other threads:[~2019-01-04 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 3:56 [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings Michael Ellerman
2019-01-01 3:56 ` [PATCH 2/2] powerpc/configs: Add PPC4xx_OCM to ppc40x_defconfig Michael Ellerman
2019-01-01 16:52 ` [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings LEROY Christophe
2019-01-02 11:12 ` Michael Ellerman
2019-01-02 11:31 ` [1/2] " Michael Ellerman
2019-01-04 20:46 ` Christian Lamparter [this message]
2019-01-08 9:54 ` Michael Ellerman
2019-01-08 17:21 ` Christian Lamparter
2019-01-11 13:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3480116.KzcvcCly6l@debian64 \
--to=chunkeey@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).