From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF4EEC3DA78 for ; Tue, 17 Jan 2023 06:39:06 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Nwzkd1yTpz3c9Q for ; Tue, 17 Jan 2023 17:39:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=BLRTAn/V; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=ajd@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=BLRTAn/V; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NwzjW28W9z30CT for ; Tue, 17 Jan 2023 17:38:06 +1100 (AEDT) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30H3i4Lx009684; Tue, 17 Jan 2023 06:37:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Li1l2T9uLNPLcqtqD1L/6shBC9UWxerMbsSFGJGXVZg=; b=BLRTAn/VN4yujnFuFiZmpziWRmS+FLBiPFDfQQ+L4mLNSXKxNs7reDC/5NSOJXcAt+sj cG2AyPdwK7Zk/YSSVQjvm32SljrZ/an3v0PGkzOC4kB3b9wF5ofQR8hBjQe+GW9u5EUJ 5yYb7Jig5lcF1ISr+avwttEqtbyeqhAvWO9chuDmKxuVSmPgPg0QjmBnaDRPlSQ8LhmV FFc/U5sy5b6v8knavAutxx/fJyq9XgoWwRbFq+zXwBCLgevBCCZfv9iUAXpb/uHrf6cl IlP780VFlipl06J865K8ObtHBBFewNTECM6qndPHAZsyFgR2gHs5+cqHJb3ikp+PAm56 gQ== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3n5m19328s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 06:37:47 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30GFhwLs023782; Tue, 17 Jan 2023 06:37:43 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3n3m16kdbw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 06:37:43 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30H6bfRX50266512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jan 2023 06:37:41 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5B5C720040; Tue, 17 Jan 2023 06:37:41 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D31702004B; Tue, 17 Jan 2023 06:37:40 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 17 Jan 2023 06:37:40 +0000 (GMT) Received: from [10.61.2.128] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 2C21D60306; Tue, 17 Jan 2023 17:37:38 +1100 (AEDT) Message-ID: <3523c0a8ab9e8df41091f5018fb14e41106b11e5.camel@linux.ibm.com> Subject: Re: [PATCH] powerpc/secvar: Use u64 in secvar_operations From: Andrew Donnellan To: Michael Ellerman , linuxppc-dev@lists.ozlabs.org Date: Tue, 17 Jan 2023 17:37:37 +1100 In-Reply-To: <20230112023819.1692452-1-mpe@ellerman.id.au> References: <20230112023819.1692452-1-mpe@ellerman.id.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Rg4HUheX6DB1CXjpzyhRHps1R8l6xPyT X-Proofpoint-GUID: Rg4HUheX6DB1CXjpzyhRHps1R8l6xPyT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-17_01,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=561 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 impostorscore=0 mlxscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301170053 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 2023-01-12 at 13:38 +1100, Michael Ellerman wrote: > There's no reason for secvar_operations to use uint64_t vs the more > common kernel type u64. >=20 > The types are compatible, but they require different printk format > strings which can lead to confusion. >=20 > Change all the secvar related routines to use u64. >=20 > Signed-off-by: Michael Ellerman We're going to include this patch in the next revision of our dynamic key management series. --=20 Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited