From: Arnd Bergmann <arnd@arndb.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Jia Hongtao <hongtao.jia@freescale.com>,
edubezval@gmail.com, viresh.kumar@linaro.org,
linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, scottwood@freescale.com
Subject: Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree
Date: Fri, 18 Dec 2015 23:32:33 +0100 [thread overview]
Message-ID: <3550740.QzZi28fbXg@wuerfel> (raw)
In-Reply-To: <1697588.dLcbZBRWO4@vostro.rjw.lan>
On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote:
> On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote:
> > Register the qoriq cpufreq driver as a cooling device, based on the
> > thermal device tree framework. When temperature crosses the passive trip
> > point cpufreq is used to throttle CPUs.
> >
> > Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Applied, thanks!
>
I got a randconfig build error today:
drivers/built-in.o: In function `qoriq_cpufreq_ready':
debugfs.c:(.text+0x1f4688): undefined reference to `of_cpufreq_cooling_register'
CONFIG_OF=y
CONFIG_QORIQ_CPUFREQ=y
CONFIG_THERMAL=m
CONFIG_THERMAL_OF=y
I think you need a 'depends on THERMAL' to prevent the driver from
being built-in when THERMAL=m.
Arnd
next prev parent reply other threads:[~2015-12-18 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 9:21 [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree Jia Hongtao
2015-12-14 23:58 ` Rafael J. Wysocki
2015-12-18 22:32 ` Arnd Bergmann [this message]
2016-01-11 14:54 ` 答复: " Hongtao Jia
2016-01-11 17:34 ` Scott Wood
2016-01-11 21:13 ` Arnd Bergmann
2016-02-26 18:04 ` Li Yang
2016-02-26 20:20 ` Arnd Bergmann
2016-02-26 23:07 ` Li Yang
2016-02-26 23:16 ` Arnd Bergmann
2016-02-26 23:31 ` Li Yang
2016-02-27 0:04 ` Li Yang
2016-02-27 0:08 ` Scott Wood
2016-02-27 0:41 ` Li Yang
2016-02-29 10:05 ` Arnd Bergmann
2016-02-29 14:33 ` Rafael J. Wysocki
2016-02-29 14:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3550740.QzZi28fbXg@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=hongtao.jia@freescale.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@rjwysocki.net \
--cc=scottwood@freescale.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox