From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, benh@kernel.crashing.org
Cc: anton@samba.org, paulus@samba.org, npiggin@gmail.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation
Date: Wed, 15 Feb 2017 15:06:47 +0530 [thread overview]
Message-ID: <3666477c-64c1-2a6e-7f67-88fb3aaf1289@linux.vnet.ibm.com> (raw)
In-Reply-To: <87y3xg97io.fsf@concordia.ellerman.id.au>
On Wednesday 08 February 2017 06:14 PM, Michael Ellerman wrote:
> Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
>
>> Hi mpe,
>>
>> Any update on this series. Have also fixed the naming issue with patch 12
>> and with this series applied,
>>
>> "paca->soft_enabled" becomes "paca->soft_disabled_mask"
> Yeah sorry I've been putting off dealing with it.
>
> Ideally we'd do the naming change earlier in the series, but maybe
> that's not worth it.
>
> The one thing I wanted to make sure was that regs->softe is never
> exposed to userspace. Because we're changing its semantics, and user
> space has no business knowing about it.
>
> So I just checked the code, and we do allow userspace to see the softe
> value. So I think we should fix that before this goes in.
>
> The safest option is to just hardwire it to 1, as that's the value it
> should always have in a userspace pt_regs.
Ok let me look at this, currently I do see the "softe" used
to decide on the return_irq path and does not look straight
forward change.
Maddy
>
> cheers
>
prev parent reply other threads:[~2017-02-15 9:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 13:36 [PATCH v6 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 01/12] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 02/12] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 03/12] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2017-01-10 5:48 ` Nicholas Piggin
2017-01-09 13:36 ` [PATCH v6 04/12] powerpc: Add soft_enabled manipulation functions Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 05/12] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2017-01-10 5:52 ` Nicholas Piggin
2017-01-09 13:36 ` [PATCH v6 06/12] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 07/12] Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 08/12] powerpc: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 09/12] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT Madhavan Srinivasan
2017-01-10 5:54 ` Nicholas Piggin
2017-01-09 13:36 ` [PATCH v6 10/12] powerpc: Add new set of soft_enabled_ functions Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 11/12] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 12/12] powerpc: Rename soft_enabled to soft_disabled_mask Madhavan Srinivasan
2017-01-10 6:02 ` Nicholas Piggin
2017-02-07 4:22 ` [PATCH v6 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-02-08 12:44 ` Michael Ellerman
2017-02-15 9:36 ` Madhavan Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3666477c-64c1-2a6e-7f67-88fb3aaf1289@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).