From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0ED1F01832 for ; Fri, 6 Mar 2026 12:22:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fS5CF2PSwz3cBW; Fri, 06 Mar 2026 23:22:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772795954; cv=none; b=KbZX01svQ2Y8WsOMbviH5MK/OT4Ks2dOOSsOzJIiWIx15EZQ6sznjHlj3Y5qA7S/UHsirzC1358AOA/pNOnk8++Eiu52MLnzksOfFh91nP7g8N2Ow1eduHTytHbpnbphnXdYC6i7KvMxPmkWieqJXO0VbvEhmrODtPcoAURdv0W+lCX0ZHJf8xAm5bPvRjUQVW21rTLhwieE6XQgYcQF0ppoSEBeakLEgeab5AVZ7k5VJZphucbe2UmCe5B9zw2hPANcXJwkBpkzzJcvdLSaJbN+NWAQfYBdzGunC297A83Lh3fH6oarb5sCp2fS2EV/l3spaAAKJWD2IK9v/I8v5w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772795954; c=relaxed/relaxed; bh=Mao5sDzSUZ+f9uQRGE4C9WfuIvF/XWcry+r5NOvZOYk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V1RiShiDe04yHva+SQab71rp5KrRwLSt7g6dLLueXO7yYxyc8a+PCuF5kUDPFJilkUkULvNS9gq0JR5soQ2aP8mVJC6Q8wh4Jpo7yJP2bjrvXnRVXiChqzPyC7XR/sDNPtAumoA5voWsi1jVevvZT8MG8rSzAYcuaad7o35vMPj6sE5Fe9fOB4qR0bH92KAiRaYnpiNAsaf2GW1+CZNI6vytNq6BBk3PB9aKMH/Po40ehOfxybtPER/hD4KLVQSMxybkS4qD24wgQJjvVkVk4P7HynFt72/3/wtgxF1ovvGXWdlva73hHoKqvdv4s2ILtPwAc/mQ5z4YRn34QOx1LA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SIoEzS/D; dkim-atps=neutral; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SIoEzS/D; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fS3nt0GRWz30T9 for ; Fri, 06 Mar 2026 22:19:13 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9820460127; Fri, 6 Mar 2026 11:19:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AD33C4CEF7; Fri, 6 Mar 2026 11:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772795950; bh=Mao5sDzSUZ+f9uQRGE4C9WfuIvF/XWcry+r5NOvZOYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SIoEzS/DxNjqL5S12WR+Z4yk2+4eKi12ei99kZadEHX7MESoV5Wv16WGPtc0njmef y90QEYTXb5wJZglbt0twBS0mvmRICjSm+Pf4pNVSyOyHKbWu/l+0AES9uhiEQcOvDj kh9D9puozrjzimBHTc3sbXUJPclGB4LyqpXKH2lNjcq9sZ/0S+5RJbLGfNQij8sk07 mEgagnudwYDACrGUEXJGJRHldgqqHPbw2M4hPETiptO3fvQnUBFuVUWhwsn15OIe8O Nd8cqwkuH0f6HODDVKq1OY5MrRDFUqGhe3otSE6QZyqmDQt7e1ZTflx4ufrWF8MyJf iV3kpykXdQjkw== Date: Fri, 6 Mar 2026 11:19:02 +0000 From: "Lorenzo Stoakes (Oracle)" To: Pedro Falcato Cc: "David Hildenbrand (Arm)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Andrew Morton , Madhavan Srinivasan , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , Muchun Song , Oscar Salvador , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Paolo Bonzini , Dan Williams Subject: Re: [PATCH v1 0/4] mm: move vma_(kernel|mmu)_pagesize() out of hugetlb.c Message-ID: <371cf0f7-4b30-4d8c-99e7-ae0543f8be23@lucifer.local> References: <20260306101600.57355-1-david@kernel.org> <4rzf46kw6hq3b5ivv7cvgyza4yfrvk2shrncytobabxef644nm@wzu2bw63co37> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4rzf46kw6hq3b5ivv7cvgyza4yfrvk2shrncytobabxef644nm@wzu2bw63co37> On Fri, Mar 06, 2026 at 11:13:41AM +0000, Pedro Falcato wrote: > On Fri, Mar 06, 2026 at 11:15:56AM +0100, David Hildenbrand (Arm) wrote: > > Looking into vma_(kernel|mmu)_pagesize(), I realized that there is one > > scenario where DAX would not do the right thing when the kernel is > > not compiled with hugetlb support. > > > > Without hugetlb support, vma_(kernel|mmu)_pagesize() will always return > > PAGE_SIZE instead of using the ->pagesize() result provided by dax-device > > code. > > > > Fix that by moving vma_kernel_pagesize() to core MM code, where it belongs. > > I don't think this is stable material, but am not 100% sure. > > > > Also, move vma_mmu_pagesize() while at it. Remove the unnecessary hugetlb.h > > inclusion from KVM code. > > > > Cross-compiled heavily. > > > > Cc: Andrew Morton > > Cc: Madhavan Srinivasan > > Cc: Nicholas Piggin > > Cc: Michael Ellerman > > Cc: "Christophe Leroy (CS GROUP)" > > Cc: Muchun Song > > Cc: Oscar Salvador > > Cc: Lorenzo Stoakes > > Cc: "Liam R. Howlett" > > Cc: Vlastimil Babka > > Cc: Mike Rapoport > > Cc: Suren Baghdasaryan > > Cc: Michal Hocko > > Cc: Jann Horn > > Cc: Pedro Falcato > > Cc: Paolo Bonzini > > Cc: Dan Williams > > Although we all love less mail, FYI it seems like this didn't work properly > for the patches (no CC's on there). > > Did you try git-email --cc-cover? Yeah I noticed this also :>) Assumed it was a new way of doing things somehow? :P > > -- > Pedro Cheers, Lorenzo