From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A337BC2BD09 for ; Thu, 27 Jun 2024 13:01:18 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=KUmBRGdI; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=Id5amWiO; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W8zGN0x4bz3cWy for ; Thu, 27 Jun 2024 23:01:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=KUmBRGdI; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=Id5amWiO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arndb.de (client-ip=103.168.172.154; helo=fhigh3-smtp.messagingengine.com; envelope-from=arnd@arndb.de; receiver=lists.ozlabs.org) Received: from fhigh3-smtp.messagingengine.com (fhigh3-smtp.messagingengine.com [103.168.172.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W8zFS1Lf2z3cTj for ; Thu, 27 Jun 2024 23:00:27 +1000 (AEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 690011140297; Thu, 27 Jun 2024 09:00:25 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Thu, 27 Jun 2024 09:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1719493225; x=1719579625; bh=SaPRVN9+Aj gKYt7eKG84QyPDe0b8SyRoJDobeWJkzD8=; b=KUmBRGdIUf5FWf7rQXCmh7UHb8 iWaNMubHRVwhjcJ6jdNkq5OXjuKH9rHOsL1aS8A5sttLGDMIsmha3zr58XJY6XTU Oyel/FgZYQcddBNZ0/eJk4xbrhL0xiEROWbKANigGKyAzWAVhqpHA4SoETJxXrhM n2ea3NKDk2ChSj87houXAh9dQMwk6M0WLY6VwTr0q38ZD9NKd9Y4cxE01SeL+p6w fO5MicY21BFRxhMAvUhFWN8N3b0Ji5Tc8VCBau8hQ0Y78vMqZLLEL195NQ5f3j15 mKpObT/xfDU+NVHR7j9lkQJjSojtbnDftSPXNSfVEyvhiWvvBg5iGtvUxByg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719493225; x=1719579625; bh=SaPRVN9+AjgKYt7eKG84QyPDe0b8 SyRoJDobeWJkzD8=; b=Id5amWiO2NMu6jmK6d2q/dqQpdqYpWoqufPq03NVdbOU BDPRxQbgjmmP5zgJkfcjVRUMtkduBZvJHwzp4mgo7FO0s9OLetP2MrvbwOYhvu4T 5P/t8G0r/v2513+x7WbHqpsAhVsAOT5B2V5Mp7+fiPy/XXr3SbYHTRlAR1LVH7Wm Kj0uLqROh+eNxBLg2NCeTGqtLTMc1Q0lnGFFtmOimxQP+iO5PbGOhR2w0wFlbdv8 zHdPOdPCUdYwmAavm740u99rAr+xP5ucHMrm0D0XI3346j9JDnDk3pRtJa4LuUvi f1fcuI5J+63rAsBXBB1ZFGwv97dZnGceCv6k0LHr5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdeggdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 176F5B6008D; Thu, 27 Jun 2024 09:00:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa MIME-Version: 1.0 Message-Id: <3732da73-ecad-4415-bfa7-0f9ad6b2a58e@app.fastmail.com> In-Reply-To: References: Date: Thu, 27 Jun 2024 15:00:03 +0200 From: "Arnd Bergmann" To: "Naresh Kamboju" , "open list" , linuxppc-dev , linux-mm , lkft-triage@lists.linaro.org, "Linux Regressions" Subject: Re: powerpc: nvram_64.c:75:13: error: 'oops_to_nvram' used but never defined [-Werror] Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , Anders Roxell , Nicholas Piggin , "Aneesh Kumar K.V" , Christophe Leroy , "Naveen N. Rao" , Andrew Morton , Dan Carpenter Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jun 27, 2024, at 14:49, Naresh Kamboju wrote: > The powerpc builds failed on Linux next-20240626 tag due to following > ---- > arch/powerpc/kernel/nvram_64.c:79:17: error: initialization of 'void > (*)(struct kmsg_dumper *, enum kmsg_dump_reason, const char *)' from > incompatible pointer type 'void (*)(struct kmsg_dumper *, enum > kmsg_dump_reason)' [-Werror=incompatible-pointer-types] > 79 | .dump = oops_to_nvram > | ^~~~~~~~~~~~~ > arch/powerpc/kernel/nvram_64.c:79:17: note: (near initialization for > 'nvram_kmsg_dumper.dump') > arch/powerpc/kernel/nvram_64.c:645:13: error: conflicting types for > 'oops_to_nvram'; have 'void(struct kmsg_dumper *, enum > kmsg_dump_reason, const char *)' > 645 | static void oops_to_nvram(struct kmsg_dumper *dumper, > | ^~~~~~~~~~~~~ > arch/powerpc/kernel/nvram_64.c:75:13: note: previous declaration of > 'oops_to_nvram' with type 'void(struct kmsg_dumper *, enum > kmsg_dump_reason)' > 75 | static void oops_to_nvram(struct kmsg_dumper *dumper, > | ^~~~~~~~~~~~~ > arch/powerpc/kernel/nvram_64.c:75:13: error: 'oops_to_nvram' used but > never defined [-Werror] > arch/powerpc/kernel/nvram_64.c:645:13: error: 'oops_to_nvram' defined > but not used [-Werror=unused-function] > 645 | static void oops_to_nvram(struct kmsg_dumper *dumper, > | ^~~~~~~~~~~~~ > cc1: all warnings being treated as error The problem is the forward declaration that was not changed as part of commit 7e72bb7504d1 ("printk: add a short description string to kmsg_dump()"). This should fix it: diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c index e385d3164648..a9da83c4243a 100644 --- a/arch/powerpc/kernel/nvram_64.c +++ b/arch/powerpc/kernel/nvram_64.c @@ -73,7 +73,8 @@ static const char *nvram_os_partitions[] = { }; static void oops_to_nvram(struct kmsg_dumper *dumper, - enum kmsg_dump_reason reason); + enum kmsg_dump_reason reason, + const char *desc); static struct kmsg_dumper nvram_kmsg_dumper = { .dump = oops_to_nvram Arnd