From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F5B8C25B4E for ; Tue, 24 Jan 2023 10:03:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P1Mxk2B4vz3cFD for ; Tue, 24 Jan 2023 21:03:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Qrm3AJfL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::32f; helo=mail-wm1-x32f.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Qrm3AJfL; dkim-atps=neutral Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P1Mwh71dpz30NN for ; Tue, 24 Jan 2023 21:02:58 +1100 (AEDT) Received: by mail-wm1-x32f.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so623263wmq.1 for ; Tue, 24 Jan 2023 02:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e7+2ObP6hwGfYv8AoClcbY4T+NA4DE6TZB+TmM9ZmmE=; b=Qrm3AJfL/kw1YbFePRK1oUcqKcOxpjENw5HzCbfcFTD48Htaa1hSvGC/HSbVSuigeD ymfmSmQwAPDkCVcJcDW797QKZOEqV8gWVGpvLohdmWBS7UVfq5MhfwlocVGOSjaT4pu6 tZBtmjY3y/CJL6GQGIF5bHV258lDpHDnVdOPU5NABATZywZhILE7m2QCYZIJx7niHVnK ePzHLlc/I408cWUSeDAalrRBA11wkadAxv92tDdWVQRgXkDqaAzyyhqm4HkO+AYCB5oI yJMYm/e/PceuZGu/c9tonmlvYQYpGl0BVdyFJe2RxvzG41bbzAf11WY+j2EtQjuepJsY gGQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e7+2ObP6hwGfYv8AoClcbY4T+NA4DE6TZB+TmM9ZmmE=; b=vZLfOYAJxg89flOYx6tK4uYj5SGvT52QddmmJDWsByDJDbL2TNrjkaridrDMsIQvre vhPSvT1w9eAaY2TbLHZ8jv3/voeWqrjJrQJtHR1mAHkGIpKKbLz+o/LgspZ937Vs8azC 30ahJerjCvfofgIj+s7V6ohP/503L+06lTFgwCZ1S/p72vzeJ1WSrE9G980Rip9kG+PK I0o8wqdqHF00qVChxGLmbSJjIEmqXzOfrBIMV0K0+Zi2LxKov0uTUfrc5kIIxyTpVxIE q29jlKye7K5PXd0yZ4s1YzAx+j5okvp2G3FzagCpKmG1Kxv16BkU1HGmzi9D3aRT08bM fd9Q== X-Gm-Message-State: AFqh2kojiOV4kWxpyR29S+Gjshp8fqxfeWGvrwXCifTtAEURDQuB30Fi krpNalPvmZCR5h5yz4z+lcFNUw== X-Google-Smtp-Source: AMrXdXuVShf4vzB3MRnsGM1yCSL18NhLSOQCh97phU6rXE44vNaCzhjcUEtLDEHz4IHu5gDEqcTYNw== X-Received: by 2002:a05:600c:89a:b0:3cf:6e78:e2ca with SMTP id l26-20020a05600c089a00b003cf6e78e2camr34965451wmp.5.1674554575278; Tue, 24 Jan 2023 02:02:55 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l15-20020a05600c4f0f00b003d9df9e59c4sm13866978wmq.37.2023.01.24.02.02.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 02:02:54 -0800 (PST) Message-ID: <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> Date: Tue, 24 Jan 2023 11:02:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Content-Language: en-US To: Herve Codina References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20230124104232.183cc9ff@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 24/01/2023 10:42, Herve Codina wrote: > Hi Krzysztof, > > On Tue, 17 Jan 2023 12:31:09 +0100 > Krzysztof Kozlowski wrote: > >> On 13/01/2023 11:37, Herve Codina wrote: >>> Add support for the QMC (QUICC Multichannel Controller) >>> available in some PowerQUICC SoC such as MPC885 or MPC866. >>> >>> Signed-off-by: Herve Codina >>> --- >>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++++ >>> 1 file changed, 164 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml >>> new file mode 100644 >>> index 000000000000..3ec52f1635c8 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml >>> @@ -0,0 +1,164 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) >>> + >>> +maintainers: >>> + - Herve Codina >>> + >>> +description: | >>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channels within >>> + one serial controller using the same TDM physical interface routed from >>> + TSA. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - fsl,mpc885-scc-qmc >>> + - fsl,mpc866-scc-qmc >>> + - const: fsl,cpm1-scc-qmc >>> + >>> + reg: >>> + items: >>> + - description: SCC (Serial communication controller) register base >>> + - description: SCC parameter ram base >>> + - description: Dual port ram base >>> + >>> + reg-names: >>> + items: >>> + - const: scc_regs >>> + - const: scc_pram >>> + - const: dpram >>> + >>> + interrupts: >>> + maxItems: 1 >>> + description: SCC interrupt line in the CPM interrupt controller >>> + >>> + fsl,tsa: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: phandle to the TSA >>> + >>> + fsl,tsa-cell-id: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + enum: [1, 2, 3] >>> + description: | >>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) >>> + - 1: SCC2 >>> + - 2: SCC3 >>> + - 3: SCC4 >> >> Is this used as argument to tsa? If so, this should be part of fsl,tsa >> property, just like we do for all syscon-like phandles. > > Yes, indeed. > I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/number > pair (the phandle to TSA node and the TSA cell id to use) Move to fsl,tsa, not from. Best regards, Krzysztof