From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Geoff Levand <geoff@infradead.org>, linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: ps3: Improve a size determination in five functions
Date: Mon, 18 Dec 2017 21:45:33 +0100 [thread overview]
Message-ID: <37ac8110-057a-9f07-841c-03e49d48f317@users.sourceforge.net> (raw)
In-Reply-To: <128a40fe-0998-2d6c-ad56-e7b63fce7f12@infradead.org>
>> Replace the specification of data structures by variable references
>> as the parameter for the operator "sizeof" to make the corresponding size
>> determination a bit safer according to the Linux coding style convention.
>
> This would be OK,
Thanks.
> but you are also removing empty lines and changing the coding format.
* Why do you not like such a change combination?
* Do you really want to integrate further update steps in this case?
Regards,
Markus
next prev parent reply other threads:[~2017-12-18 20:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 13:50 [PATCH 0/2] PS3: Adjustments for six function implementations SF Markus Elfring
2017-12-16 13:51 ` [PATCH 1/2] ps3: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-12-18 18:22 ` Geoff Levand
2017-12-16 13:54 ` [PATCH 2/2] ps3: Improve a size determination in five functions SF Markus Elfring
2017-12-18 18:22 ` Geoff Levand
2017-12-18 20:45 ` SF Markus Elfring [this message]
2017-12-18 20:52 ` Geoff Levand
2017-12-20 19:58 ` [PATCH 2/2] " Geoff Levand
2017-12-20 21:20 ` SF Markus Elfring
2017-12-21 0:05 ` Geoff Levand
2017-12-18 18:32 ` [PATCH 0/2] PS3: Adjustments for six function implementations Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ac8110-057a-9f07-841c-03e49d48f317@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=benh@kernel.crashing.org \
--cc=geoff@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).