linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/4] powerpc: Fix 32 bits mm operations when not using BATs
Date: Thu, 22 Mar 2007 12:55:46 +0100	[thread overview]
Message-ID: <3839ac2050c6dcf8c0062b4a367b2ba9@kernel.crashing.org> (raw)
In-Reply-To: <20070322030114.D5B9FDDF2B@ozlabs.org>

> +	 * If the hash table bucket is full of kernel text entries, we'll
> +	 * lockup here but that shouldn't happen

On 32-bit we have room for one HPTE per real page -- assuming
the kernel text is fully enclosed inside one power-of-two
size and aligned range of address space (i.e. always ;-) ),
a lockup here _cannot_ happen.  It doesn't get tight until you
start using all of memory as kernel text.

So replace this comment with something like "the HTAB is
sized such that no PTEG can overflow from kernel text alone"?
It sounds a lot less hand-wavy than "but this shouldn't happen".


Segher

  parent reply	other threads:[~2007-03-22 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22  2:59 [PATCH 2/4] powerpc: Fix 32 bits mm operations when not using BATs Benjamin Herrenschmidt
2007-03-22  5:44 ` Benjamin Herrenschmidt
2007-03-22 11:55 ` Segher Boessenkool [this message]
2007-03-22 12:00   ` Benjamin Herrenschmidt
2007-03-22 12:01     ` Benjamin Herrenschmidt
2007-04-18  8:58 ` Milton Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3839ac2050c6dcf8c0062b4a367b2ba9@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).