From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B65BC4345F for ; Thu, 25 Apr 2024 14:46:17 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=google header.b=eRbKs6ry; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VQJZb559Nz3vY6 for ; Fri, 26 Apr 2024 00:46:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=google header.b=eRbKs6ry; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2607:f8b0:4864:20::435; helo=mail-pf1-x435.google.com; envelope-from=skhan@linuxfoundation.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VQJYl502vz3cnt for ; Fri, 26 Apr 2024 00:45:30 +1000 (AEST) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6f013c304bbso81494b3a.1 for ; Thu, 25 Apr 2024 07:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1714056328; x=1714661128; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Upe9hXc85SfykUK8OSJyDQtUplWhtMiTd1jA3tMRXuo=; b=eRbKs6ryiA2ApZBtsVDf0OLrTiYdZD5V7aWyTEhy5zpxupUyHZ0fDL6NtcFzR3NWpq RS+efbKyBrXrH5HANnZMIRGvKotSA+5S0JnBCHaTPgyYsll7Z8uTseQRj7r0dKOFD/54 kiEtLcWThfVs5JITJdxuX5mM4DwEX6aWxAMCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714056328; x=1714661128; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Upe9hXc85SfykUK8OSJyDQtUplWhtMiTd1jA3tMRXuo=; b=k3/+fksblFba2/q0WrvthwCMJZDl6+LB8EqKI2QBodKFhDOLWOjET5AxelMV1eH+ZN +j/eLJFrhv9wahKJKSssb+Qmg2RDEhAMN8SuMWDO2zxQSeeb5fAijeF1QwwVcFKb1cAE m0SIUapINxrcg1E+rYX3/qd2dgFVZvApMAn5mm4pQGfmqBsvuyb2dwupe6sqFgmAtRyb mdOvotviD9l0BVUmiPDyESFaDcUXKFOL6GezZfW4pHUvX08XSN5uK/TBTvhEu0TNS/nZ b4f3tTm+UF+SJ+Asq81B8zYFCd+WSjctmPy0QNuHNuY33ZKgjlmCKafvr5shwvpOSMDT Lcxw== X-Forwarded-Encrypted: i=1; AJvYcCXs6K2h2g5dr5MpBMqGuVJpELWSZXtKWQX2FICzxzk9DOCi3GRmGHUKVkecSQuguSGllOJySV2798/SoksFl1yb82CcvlS2FthYIU8mmw== X-Gm-Message-State: AOJu0Yyjck1MmaSuYn3mD/q1lEgUc/IskU4JdsecaIfTfP0JyD8Sw68X 053uYNQOqCLdLiDsjUvNgQIDtXViqFnDAlCx2ykwkfVG3Bp5bURpTyXz6zqEwzI= X-Google-Smtp-Source: AGHT+IH2ZWIxVnWGlxZ14mWcvRqLtKyE6u0gRzo1WyBlfFhqv5treC26C0VPwnpQrTOD05hYIY1E7A== X-Received: by 2002:a05:6a00:731:b0:6ea:ba47:a63b with SMTP id 17-20020a056a00073100b006eaba47a63bmr6568081pfm.0.1714056327589; Thu, 25 Apr 2024 07:45:27 -0700 (PDT) Received: from [192.168.43.82] ([223.185.79.208]) by smtp.gmail.com with ESMTPSA id k124-20020a633d82000000b005f7d61ec8afsm11351461pga.91.2024.04.25.07.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 07:45:27 -0700 (PDT) Message-ID: <3848a9ad-07aa-48da-a2b7-264c4a990b5b@linuxfoundation.org> Date: Thu, 25 Apr 2024 08:45:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 25/35] KVM: selftests: Convert lib's mem regions to KVM_SET_USER_MEMORY_REGION2 To: Dan Carpenter , Sean Christopherson , Shuah Khan , Greg Kroah-Hartman References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-26-seanjc@google.com> <69ae0694-8ca3-402c-b864-99b500b24f5d@moroto.mountain> Content-Language: en-US From: Shuah Khan In-Reply-To: <69ae0694-8ca3-402c-b864-99b500b24f5d@moroto.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , Shuah Khan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Anders Roxell , Benjamin Copeland , Marc Zyngier , Naresh Kamboju , Huacai Chen , Xiaoyao Li , "Matthew Wilcox \(Oracle\)" , Wang , Fuad Tabba , Yu Zhang , Maciej Szmigiero , Albert Ou , Vlastimil Babka , Michael Roth , Ackerley Tng , Alexander Viro , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, =?UTF- 8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Isaku Yamahata , Christian Brauner , Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , David Matlack , Jarkko Sakkinen , Palmer Dabbelt , "Kirill A . Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 4/25/24 08:12, Dan Carpenter wrote: > On Fri, Oct 27, 2023 at 11:22:07AM -0700, Sean Christopherson wrote: >> Use KVM_SET_USER_MEMORY_REGION2 throughout KVM's selftests library so that >> support for guest private memory can be added without needing an entirely >> separate set of helpers. >> >> Note, this obviously makes selftests backwards-incompatible with older KVM > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> versions from this point forward. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Is there a way we could disable the tests on older kernels instead of > making them fail? Check uname or something? There is probably a > standard way to do this... It's these tests which fail. They shouldn't fail - the tests should be skipped on older kernels. If it is absolutely necessary to dd uname to check kernel version, refer to zram/zram_lib.sh for an example. thanks, -- Shuah