From: Segher Boessenkool <segher@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes.
Date: Thu, 10 May 2007 08:57:52 +0200 [thread overview]
Message-ID: <385038798e00654a5cbd38165b06734b@kernel.crashing.org> (raw)
In-Reply-To: <20070509182630.GA19495@ld0162-tx32.am.freescale.net>
>>>>>> As I previously wrote internally, it's only needed because some
>>>>>> versions of the device have it and some don't; what it really
>>>>>> means
>>>>>> is that certain bits in certain registers are valid.
>>
>> So have the driver detect this based on "compatible"
>> or "model".
>
> Thus requiring the driver to maintain a list of models/compatibles for
> every possible combination of features,
Most likely a very short list. But you know best
of course.
> rather than letting the device
> tree specify them individually. What would be the advantage in that?
It's a tradeoff -- describing every single bit of
the hardware in the device tree is a way bigger
maintenance burden, be careful not to go overboard
with it.
Segher
next prev parent reply other threads:[~2007-05-10 6:58 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 18:29 [PATCH 01/13] Clean up formatting in Documentation/booting-without-of.txt Scott Wood
2007-05-07 18:29 ` [PATCH 02/13] Document devtree binding for power management controllers Scott Wood
2007-05-08 0:19 ` David Gibson
2007-05-07 18:29 ` [PATCH 03/13] Document the sleep property Scott Wood
2007-05-08 2:11 ` Olof Johansson
2007-05-08 15:23 ` Scott Wood
2007-05-07 18:29 ` [PATCH 04/13] Document the devtree binding for general purpose timers Scott Wood
2007-05-07 18:29 ` [PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes Scott Wood
2007-05-07 21:27 ` Andy Fleming
2007-05-07 21:29 ` Scott Wood
2007-05-07 21:51 ` Andy Fleming
2007-05-07 23:06 ` Kumar Gala
2007-05-08 0:18 ` David Gibson
2007-05-09 14:33 ` Segher Boessenkool
2007-05-09 18:26 ` Scott Wood
2007-05-10 6:57 ` Segher Boessenkool [this message]
2007-05-08 15:29 ` Scott Wood
2007-05-07 18:29 ` [PATCH 06/13] Make swsusp_32.S usable for suspend-to-RAM Scott Wood
2007-05-07 18:29 ` [PATCH 07/13] Implement arch disable/enable irq hooks Scott Wood
2007-05-21 15:55 ` Johannes Berg
2007-05-22 7:14 ` Benjamin Herrenschmidt
2007-05-22 9:03 ` Johannes Berg
2007-05-22 9:15 ` Benjamin Herrenschmidt
2007-05-22 9:24 ` Johannes Berg
2007-05-07 18:29 ` [PATCH 08/13] pm: Handle HID0_SLEEP in the TLF_NAPPING hack Scott Wood
2007-05-07 18:29 ` [PATCH 09/13] fsl_soc: Factor fsl_get_bus_freq() out of the wdt init Scott Wood
2007-05-10 3:36 ` Kumar Gala
2007-05-10 15:49 ` Scott Wood
2007-05-10 15:59 ` Kumar Gala
2007-05-07 18:29 ` [PATCH 10/13] mpc83xx: Power Management support Scott Wood
2007-05-22 21:08 ` Guennadi Liakhovetski
2007-05-22 21:16 ` Scott Wood
2007-05-07 18:29 ` [PATCH 11/13] mpc83xx: timer driver for PM wakeup Scott Wood
2007-05-07 18:29 ` [PATCH 12/13] gianfar: Add flags for magic packet and MDIO Scott Wood
2007-05-07 19:52 ` Kumar Gala
2007-05-07 19:54 ` Scott Wood
2007-05-07 20:00 ` Kumar Gala
2007-05-07 21:25 ` Andy Fleming
2007-05-07 21:31 ` Scott Wood
2007-05-07 21:56 ` Andy Fleming
2007-05-07 21:45 ` Andy Fleming
2007-05-07 21:53 ` Scott Wood
2007-05-07 21:59 ` Andy Fleming
2007-05-07 23:11 ` Kumar Gala
2007-05-07 23:36 ` Andy Fleming
2007-05-07 18:30 ` [PATCH 13/13] gianfar: Magic Packet and suspend/resume support Scott Wood
2007-05-08 0:20 ` [PATCH 01/13] Clean up formatting in Documentation/booting-without-of.txt David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=385038798e00654a5cbd38165b06734b@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).