From: Michel Dänzer <michdaen@iiic.ethz.ch>
To: khendricks@ivey.uwo.ca
Cc: Kostas Gewrgiou <gewrgiou@imbc.gr>,
Ani Joshi <ajoshi@shell.unixbox.com>,
linuxppc-dev@lists.linuxppc.org
Subject: Re: Found bug in mode switching but who is at fault...XFree86 or aty128fb.c?
Date: Sat, 25 Mar 2000 08:57:37 +0100 [thread overview]
Message-ID: <38DC7171.735D9DF5@iiic.ethz.ch> (raw)
In-Reply-To: 00032423100100.00584@localhost.localdomain
Kevin Hendricks wrote:
> Okay so I found the bug. It seems all through the r128 driver, crtc.pitch
> values are set to the virtual x resolution (vxres) / 8. But in aty128fb.c
> in the var_to_crtc routine the crtc.pitch is set to be just the xres / 8.
>
> This is not a problem if xres == vxres. Which is what happens when the
> aty128fb.c starts up.
Not necessarily. The problem could have shown up if someone had put a mode
with xres < vxres as first in the "Modes" line, but apparently only
configuration tools tend to do that...
> So for any one mode it defaults to being okay.
Okay.
> Who is wrong? Should xfree shrink the vxres and vyres to match xres and
> yres before calling set_var or should aty128fb.c var_to_crtc routine be
> fixed to use vxres >> 3 instead of just xres >> 3?
I vote for the latter, because otherwise invisible parts of the screen may be
damaged, or am I wrong?
A better reason might be that it works perfectly as-is in glint ;)
Michel
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2000-03-25 7:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.10.10003230911180.6826-100000@shell.unixbox.com>
2000-03-23 18:16 ` Some issues to resolve with XFree 4.0 yet Kevin Hendricks
2000-03-25 3:54 ` Found bug in mode switching but who is at fault...XFree86 or aty128fb.c? Kevin Hendricks
2000-03-25 7:57 ` Michel Dänzer [this message]
2000-03-25 8:07 ` Michel Dänzer
2000-03-25 13:46 ` Geert Uytterhoeven
2000-03-25 23:50 ` Some issues to resolve with XFree 4.0 yet Kevin Hendricks
2000-03-27 11:09 ` Kostas Gewrgiou
2000-03-27 17:41 ` Ryuichi Oikawa
2000-03-27 18:05 ` Ani Joshi
2000-03-27 19:06 ` Kevin B. Hendricks
2000-03-27 19:13 ` David Edelsohn
2000-03-27 19:20 ` Kevin B. Hendricks
2000-03-27 19:25 ` Ani Joshi
2000-03-27 19:45 ` David Edelsohn
2000-03-27 19:38 ` Ani Joshi
2000-03-27 20:01 ` David Edelsohn
2000-03-27 19:48 ` Kevin B. Hendricks
2000-03-28 7:59 ` Geert Uytterhoeven
2000-03-29 10:45 ` Gabriel Paubert
2000-03-29 13:11 ` Franz Sirl
2000-03-29 14:58 ` Gabriel Paubert
2000-03-29 19:39 ` Franz Sirl
2000-03-28 16:51 ` Ryuichi Oikawa
2000-03-28 17:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38DC7171.735D9DF5@iiic.ethz.ch \
--to=michdaen@iiic.ethz.ch \
--cc=ajoshi@shell.unixbox.com \
--cc=gewrgiou@imbc.gr \
--cc=khendricks@ivey.uwo.ca \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).